-
Notifications
You must be signed in to change notification settings - Fork 190
[INFRA] Update code for assemble of contributors records and extend listing of referenced contributors #1964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1964 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 20 20
Lines 1608 1608
=======================================
Hits 1330 1330
Misses 278 278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b999731 to
ee61888
Compare
3626e29 to
e10d2d1
Compare
|
converting to draft:
|
|
TODO (but for future PRs):
|
bendhouseart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
=== Do not change lines below ===
{
"chain": [],
"cmd": "tributors update-lookup",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
…cates I am blaming tributors somewhere adding them from commits
|
I pushed some more changes but we gained some dups... I bet |
|
@yarikoptic Are we good to go? |
to avoid duplicate... I think tributors manages to duplicate
But changes to .all-contributorsrc were "suboptimal" so not committed
| { | ||
| "avatar_url": [ | ||
| "https://avatars.githubusercontent.com/u/47249340?v=4" | ||
| ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when is it a list and when it is not? I wonder what makes it jump ... too much in this cocktail mixer ATM which mess with this file:
- tributors: https://github.com/con/tributors/blob/HEAD/tributors/main/parsers/allcontrib.py
- here we have http://github.com/Remi-Gau/bids-specification/blob/HEAD/tools/add_contributors.py
- and then
npx all-contributors generate
uff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. Does it make a difference if it's a list or not?
|
FWIW, my motivation here was to address website validation fail. Using branch we get down to 10 (although re-introduce some; 9 unique)❯ python validate_people.py | grep 'NOT FO' | nl
1 NOT FOUND Julia Guiomar Niso Galán
2 NOT FOUND Andrew Davison
3 NOT FOUND Eric Earl
4 NOT FOUND Samuel Diebolt
5 NOT FOUND Seyed Yahya Shirazi
6 NOT FOUND Seyed Yahya Shirazi
7 NOT FOUND Mary Miedema
8 NOT FOUND Stefano Moia
9 NOT FOUND Sourav Kulkarni
10 NOT FOUND Robert Smithfrom 12❯ python validate_people.py | grep 'NOT FO' | nl
1 NOT FOUND Andrew Davison
2 NOT FOUND Eric Earl
3 NOT FOUND Sebastian Urchs
4 NOT FOUND Jean-Charles Mariani
5 NOT FOUND Samuel Diebolt
6 NOT FOUND Thomas Deffieux
7 NOT FOUND Seyed Yahya Shirazi
8 NOT FOUND Seyed Yahya Shirazi
9 NOT FOUND Mary Miedema
10 NOT FOUND Stefano Moia
11 NOT FOUND Sourav Kulkarni
12 NOT FOUND Robert Smithideally we fixup for that ... but may be in a follow up -- and just consider this to improvement for now? |
|
Yeah, I think this is big enough as-is, and we've spammed people's notifications long enough. Cleanups can come separately. |
|
and I think there is actually a bug there in metadata or validator script -- incorrect composition or split of names... e.g. @neuromechanist -- your given names are both .all-contributors and .tributors have only composite "name" and not split. CITATION.cff and beps.yaml -- split given/family. So we are doing dances splitting / recomposing and doing that incorrectly! Ideally, So, yeah, let's proceed for now! |
|
Damn. I should have squashed so emails that were not meant to be public weren't left in the history. |
…isting of referenced contributors (#1964) Co-authored-by: Yaroslav O. Halchenko <[email protected]> Co-authored-by: Christopher J. Markiewicz <[email protected]> Co-authored-by: melanieganz <[email protected]> Co-authored-by: Julia Guiomar Niso Galán <[email protected]> Co-authored-by: Remi Gau <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.