Skip to content

Conversation

@Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Oct 20, 2024

@Remi-Gau Remi-Gau added the exclude-from-changelog This item will not feature in the automatically generated changelog label Oct 20, 2024
@Remi-Gau Remi-Gau changed the title update contributors [MAINT] update contributors Oct 20, 2024
@codecov
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.71%. Comparing base (4b5cafb) to head (25e132b).
⚠️ Report is 108 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1964   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files          20       20           
  Lines        1608     1608           
=======================================
  Hits         1330     1330           
  Misses        278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Remi-Gau Remi-Gau marked this pull request as draft October 21, 2024 07:48
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Oct 21, 2024

converting to draft:

  • check if some of the new contributors have a github account (I know some do)
  • need to add a few more contributors from some recently developed BIDS tools

@Remi-Gau
Copy link
Collaborator Author

TODO (but for future PRs):

  • add github usernames to contributors who have one
  • update affiliations (help to know where our contributors are from)
  • check people who have contributed to repos on BIDS and BIDS apps github organization, tools / converters repos...
  • check people mentioned on BIDS papers (that probably should be listed as contributors ?)

@Remi-Gau Remi-Gau marked this pull request as ready for review October 21, 2024 11:31
Copy link
Collaborator

@bendhouseart bendhouseart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "tributors update-lookup",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
…cates

I am blaming tributors somewhere adding them from commits
@yarikoptic
Copy link
Collaborator

I pushed some more changes but we gained some dups... I bet tributors somewhere too zealous or smth like that.

@effigies effigies mentioned this pull request Aug 27, 2025
@effigies
Copy link
Collaborator

@yarikoptic Are we good to go?

@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Aug 27, 2025
@effigies effigies changed the title [MAINT] Update code for assemble of contributors records and extend listing of referenced contributors [INFRA] Update code for assemble of contributors records and extend listing of referenced contributors Aug 27, 2025
to avoid duplicate... I think tributors manages to duplicate
But changes to .all-contributorsrc were "suboptimal" so not committed
{
"avatar_url": [
"https://avatars.githubusercontent.com/u/47249340?v=4"
],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when is it a list and when it is not? I wonder what makes it jump ... too much in this cocktail mixer ATM which mess with this file:

uff

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. Does it make a difference if it's a list or not?

@yarikoptic
Copy link
Collaborator

FWIW, my motivation here was to address website validation fail. Using branch we get

down to 10 (although re-introduce some; 9 unique)
❯ python validate_people.py | grep 'NOT FO' | nl
     1	    NOT FOUND Julia Guiomar Niso Galán
     2	    NOT FOUND Andrew Davison
     3	    NOT FOUND Eric Earl
     4	    NOT FOUND Samuel Diebolt
     5	    NOT FOUND Seyed Yahya Shirazi
     6	    NOT FOUND Seyed Yahya Shirazi
     7	    NOT FOUND Mary Miedema
     8	    NOT FOUND Stefano Moia
     9	    NOT FOUND Sourav Kulkarni
    10	    NOT FOUND Robert Smith
from 12
❯ python validate_people.py | grep 'NOT FO' | nl
     1	    NOT FOUND Andrew Davison
     2	    NOT FOUND Eric Earl
     3	    NOT FOUND Sebastian Urchs
     4	    NOT FOUND Jean-Charles Mariani
     5	    NOT FOUND Samuel Diebolt
     6	    NOT FOUND Thomas Deffieux
     7	    NOT FOUND Seyed Yahya Shirazi
     8	    NOT FOUND Seyed Yahya Shirazi
     9	    NOT FOUND Mary Miedema
    10	    NOT FOUND Stefano Moia
    11	    NOT FOUND Sourav Kulkarni
    12	    NOT FOUND Robert Smith

ideally we fixup for that ... but may be in a follow up -- and just consider this to improvement for now?

@effigies
Copy link
Collaborator

Yeah, I think this is big enough as-is, and we've spammed people's notifications long enough. Cleanups can come separately.

@yarikoptic
Copy link
Collaborator

and I think there is actually a bug there in metadata or validator script -- incorrect composition or split of names... e.g. @neuromechanist -- your given names are Seyed Yahya or just Seyed (and then family name Yahya Shirazi)?

both .all-contributors and .tributors have only composite "name" and not split. CITATION.cff and beps.yaml -- split given/family. So we are doing dances splitting / recomposing and doing that incorrectly! Ideally, .tributors should unify into a split version. FWIW filed

So, yeah, let's proceed for now!

@effigies effigies merged commit 3d4a584 into bids-standard:master Aug 27, 2025
27 checks passed
@effigies
Copy link
Collaborator

Damn. I should have squashed so emails that were not meant to be public weren't left in the history.

effigies added a commit that referenced this pull request Aug 27, 2025
…isting of referenced contributors (#1964)

Co-authored-by: Yaroslav O. Halchenko <[email protected]>
Co-authored-by: Christopher J. Markiewicz <[email protected]>
Co-authored-by: melanieganz <[email protected]>
Co-authored-by: Julia Guiomar Niso Galán <[email protected]>
Co-authored-by: Remi Gau <[email protected]>
@Remi-Gau Remi-Gau deleted the contributors branch August 28, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copenhagen For discussion in Copenhagen exclude-from-changelog This item will not feature in the automatically generated changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.