Skip to content

[ENH] BEP042 - extension for electromyography (EMG) #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

[ENH] BEP042 - extension for electromyography (EMG) #1998

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
187ce78
BEP 042: Electromyography (EMG)
drammock Dec 5, 2024
26346de
formatting: remove equals sign from definitions
drammock Oct 21, 2025
88eea21
clarify: no quotes for description column values
drammock Oct 21, 2025
fafb3f1
add Preamplification and Gain as recommended fields to emg.json
drammock Oct 21, 2025
e009b96
clarify: where to specify IED and ElectrodeMaterial in different scen…
drammock Oct 21, 2025
4e9adcd
harmonize LATENCY definition with BIDS-Motion
drammock Oct 21, 2025
afaa9e1
add passage about multi-modal synchronization
drammock Oct 21, 2025
e6ecd33
fmt: remark (space between list items); runprettier
drammock Oct 22, 2025
3f2fdcf
better validation (and comments)
drammock Oct 22, 2025
78701a1
Merge remote-tracking branch 'upstream/master' into emg
effigies Nov 13, 2025
4f238ab
fix: Move sidecar constraint into sidecar section
effigies Nov 13, 2025
c233edd
add units
drammock Nov 14, 2025
b56863a
make preamp and gain optional
drammock Nov 14, 2025
b74dcbf
add EMG channel count rule
drammock Nov 20, 2025
4737a23
tweak sidecar REQ/REC/OPT
drammock Nov 20, 2025
9b913a4
DRY
drammock Nov 20, 2025
7500d38
Merge branch 'master' into emg
drammock Nov 20, 2025
04b2638
make it required
drammock Nov 20, 2025
116f798
remove dB unit
drammock Nov 20, 2025
d0a1ead
move corresponding narrative chunk from recommended to required section
drammock Nov 20, 2025
21d0c16
remove outdated TODOs
drammock Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/schema/rules/sidecars/electrophys.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
---
EpochedData:
selectors:
- intersects([datatype], ['eeg', 'meg', 'ieeg'])
- intersects([datatype], ['eeg', 'emg', 'meg', 'ieeg'])
- sidecar.RecordingType == 'epoched'
fields:
EpochLength: recommended
11 changes: 2 additions & 9 deletions src/schema/rules/sidecars/emg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,6 @@ EMGRecommended:
HardwareFilters: recommended
RecordingDuration: recommended

EMGEpoched:
selectors:
- datatype == "emg"
- suffix == "emg"
- sidecar.RecordingType == "epoched"
fields:
EpochLength: required

# Specific EMG fields MAY be present
EMGOptional:
selectors:
Expand All @@ -92,7 +84,8 @@ EMGOptional:
EMGGround: optional
EpochLength:
level: optional
level_addendum: required if `RecordingType` is `"epoched"`
# Implemented in rules.sidecars.electrophys
level_addendum: recommended if RecordingType is "epoched"
Gain: optional
InterelectrodeDistance: optional
Preamplification: optional
Expand Down
Loading