Skip to content

Commit 1325d9a

Browse files
effigiesrwblair
andauthored
Apply suggestions from code review
Co-authored-by: Ross Blair <[email protected]>
1 parent bc3fe72 commit 1325d9a

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

.github/CONTRIBUTING.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@ consider:
104104

105105
## Developing for the validator
106106

107-
When proposing a feature or bug fix, you must decide what branch you will target:
107+
When proposing a feature or bug fix, you must decide which branch you will target:
108108
`main` or `dev`.
109-
In most cases, you will want `main`, but read below to understand the purposes of
109+
In most cases you will want `main`, but read below to understand the purposes of
110110
the two branches.
111111

112112
### Branching policy
@@ -121,7 +121,7 @@ specification.
121121
The purpose of this branch is to verify that proposed rules can be validated and
122122
provide users with preview access to upcoming changes to the validator, increasing the chances
123123
of catching issues with the specification or the validator, prior to release.
124-
Changes to the `dev` branch may be backed out at any time.
124+
Changes to the `dev` branch may be reverted at any time.
125125

126126
### How to prepare a pull request for your target branch
127127

@@ -138,13 +138,13 @@ from the current state of the `main` branch on the `upstream` remote.
138138
Instead of `short-desc`, use a few words to make the content of your branch
139139
easily identifiable.
140140

141-
Once ready
141+
Once you have changes committed and ready for review you can run:
142142

143143
```console
144144
git push -u origin feat/short-desc
145145
```
146146

147-
GitHub will give you a link, such as
147+
GitHub will then give you a link such as:
148148
<https://github.com/bids-standard/bids-validator/compare/master...username:bids-validator:feat/short-desc?expand=1>.
149149
Follow that link to create a pull request.
150150

0 commit comments

Comments
 (0)