Skip to content

Commit d302b3d

Browse files
authored
Merge pull request #238 from nellh/variadic-options-fix
fix: Use string[] options for datasetTypes and blacklistModalities
2 parents dff1f7f + 523f45e commit d302b3d

File tree

2 files changed

+49
-2
lines changed

2 files changed

+49
-2
lines changed
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
<!--
2+
A new scriv changelog fragment.
3+
4+
Uncomment the section that is right (remove the HTML comment wrapper).
5+
For top level release notes, leave all the headers commented out.
6+
-->
7+
8+
<!--
9+
### Added
10+
11+
- A bullet item for the Added category.
12+
13+
-->
14+
### Changed
15+
16+
- `--datasetTypes` and `--blacklistModalities` options now accept a string array (`--datasetTypes raw,derivative`) and can be combined.
17+
18+
<!--
19+
### Fixed
20+
21+
- A bullet item for the Fixed category.
22+
23+
-->
24+
<!--
25+
### Deprecated
26+
27+
- A bullet item for the Deprecated category.
28+
29+
-->
30+
<!--
31+
### Removed
32+
33+
- A bullet item for the Removed category.
34+
35+
-->
36+
<!--
37+
### Security
38+
39+
- A bullet item for the Security category.
40+
41+
-->
42+
<!--
43+
### Infrastructure
44+
45+
- A bullet item for the Infrastructure category.
46+
47+
-->

src/setup/options.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,13 @@ export const validateCommand: Command<void, void, any, string[], void> = new Com
7676
)
7777
.type('datasetType', datasetType)
7878
.option(
79-
'--datasetTypes <...datasetTypes:datasetType>',
79+
'--datasetTypes <datasetTypes:datasetType[]>',
8080
'Permitted dataset types to validate against (default: all)',
8181
{ default: [] as string[] },
8282
)
8383
.type('modality', modalityType)
8484
.option(
85-
'--blacklistModalities <...modalities:modality>',
85+
'--blacklistModalities <modalities:modality[]>',
8686
'Array of modalities to error on if detected.',
8787
{ default: [] as string[] },
8888
)

0 commit comments

Comments
 (0)