fix(tests): Pass TSV data as stream in regression test

Author: effigies

src/files/streams.test.ts

@@ -1,14 +1,6 @@
 import { assert, assertEquals } from '@std/assert'
 import { createUTF8Stream, UnicodeDecodeError } from './streams.ts'
-
-function streamFromUint8Array(arr: Uint8Array): ReadableStream<Uint8Array> {
-  return new ReadableStream({
-    start(controller) {
-      controller.enqueue(arr)
-      controller.close()
-    },
-  })
-}
+import { streamFromUint8Array, streamFromString } from '../tests/utils.ts'
 
 Deno.test('createUTF8Stream', async (t) => {
   await t.step('should return a TransformStream with UTF8StreamTransformer', () => {
@@ -17,7 +9,7 @@ Deno.test('createUTF8Stream', async (t) => {
   })
 
   await t.step('should correctly transform UTF-8 input', async () => {
-    const rawstream = streamFromUint8Array(new TextEncoder().encode('Hello, world!'))
+    const rawstream = streamFromString('Hello, world!')
     const reader = rawstream.pipeThrough(createUTF8Stream()).getReader()
     const { value } = await reader.read()
     assertEquals(value, 'Hello, world!')

src/files/tsv.test.ts

@@ -1,17 +1,9 @@
 import { assert, assertEquals, assertObjectMatch } from '@std/assert'
 import { pathToFile } from './filetree.ts'
 import { loadTSV } from './tsv.ts'
+import { streamFromString } from '../tests/utils.ts'
 import { ColumnsMap } from '../types/columns.ts'
 
-function streamFromString(str: string): ReadableStream<Uint8Array> {
-  return new ReadableStream({
-    start(controller) {
-      controller.enqueue(new TextEncoder().encode(str))
-      controller.close()
-    },
-  })
-}
-
 Deno.test('TSV loading', async (t) => {
   await t.step('Empty file produces empty map', async () => {
     const file = pathToFile('/empty.tsv')

src/tests/regression.test.ts

@@ -2,6 +2,7 @@ import { assert } from '@std/assert'
 import { pathsToTree } from '../files/filetree.ts'
 import { validate } from '../validators/bids.ts'
 import type { BIDSFile } from '../types/filetree.ts'
+import { streamFromString } from './utils.ts'
 
 Deno.test('Regression tests', async (t) => {
   await t.step('Verify ignored files in scans.tsv do not trigger error', async () => {
@@ -17,7 +18,7 @@ Deno.test('Regression tests', async (t) => {
     // Without ignore, NOT_INCLUDED is triggered for CT, but the scans file is happy
     let ds = pathsToTree(paths)
     let scans_tsv = ds.get('sub-01/sub-01_scans.tsv') as BIDSFile
-    scans_tsv.text = () => Promise.resolve(scans_content)
+    scans_tsv.stream = streamFromString(scans_content)
     let result = await validate(ds, {
       datasetPath: '/dataset',
       debug: 'ERROR',
@@ -30,7 +31,7 @@ Deno.test('Regression tests', async (t) => {
     // With ignore, NOT_INCLUDED is not triggered for CT, and the scans file is still happy
     ds = pathsToTree(paths, ignore)
     scans_tsv = ds.get('sub-01/sub-01_scans.tsv') as BIDSFile
-    scans_tsv.text = () => Promise.resolve(scans_content)
+    scans_tsv.stream = streamFromString(scans_content)
     result = await validate(ds, {
       datasetPath: '/dataset',
       debug: 'ERROR',

src/tests/utils.ts

@@ -0,0 +1,12 @@
+export function streamFromUint8Array(arr: Uint8Array): ReadableStream<Uint8Array> {
+  return new ReadableStream({
+    start(controller) {
+      controller.enqueue(arr)
+      controller.close()
+    },
+  })
+}
+
+export function streamFromString(str: string): ReadableStream<Uint8Array> {
+  return streamFromUint8Array(new TextEncoder().encode(str))
+}