Skip to content

Add warning for overridden sidecar fields #117

Open
@effigies

Description

@effigies

bids-standard/bids-specification#1834 proposes RECOMMENDING against overriding JSON values as a source of confusion ("I can see this value in my JSON, why is the tool using a different one?")

This should be relatively easy to implement by checking for overlap here:

this.sidecar = { ...json, ...this.sidecar }
Object.keys(json).map((x) => this.sidecarKeyOrigin[x] ??= file.path)

Added a target: dev label to indicate PRs should target the dev branch, not main, as this would be a spec change.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions