Skip to content

Validator reports internal HED errors when constructing invalid objects when more specific errors are available #444

Description

@happy5214

It was reported at hed-standard/hed-javascript#836 (comment) that the validator is reporting HED_ERROR with an INTERNAL_ERROR subcode for what turns out to be IssueErrors thrown from the construction of BidsFile objects which fail basic validation. As with the schema construction, the IssueErrors have more specific information which can be used to build a more useful issue message. At the very least, the schema error-catching code should be copied for the file-building code, with internal errors reserved for uncaught errors from actual validation.

If nobody gets to it in the next couple of days, I'll take care of it myself.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions