Skip to content

Conversation

@effigies
Copy link
Contributor

Done after reviewing #156.

@happy5214
Copy link
Contributor

happy5214 commented Feb 10, 2025

With a chance to review this now, file.validate() shouldn't even be called if the schema is null. The validation will never succeed with a null schema set (it just returns null itself, the probable cause of #145). That needs to be fixed.

@happy5214
Copy link
Contributor

@effigies Please merge this. I plan on making my own changes off of this PR to complete the work on this module.

@effigies effigies merged commit c408125 into bids-standard:main Feb 10, 2025
17 checks passed
@effigies effigies deleted the lint/src-validators-hed branch February 10, 2025 20:41
@effigies
Copy link
Contributor Author

@happy5214 Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants