Clean up HED module issues #160
Merged
+17
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It appears the tests are expecting two HED errors? I only know of one (a failed schema load due to an invalid specification), so I don't know what the other intended error was (perhaps the caught internal error from the spread syntax?). Please investigate. |
Contributor
Author
|
Tagging @VisLab. |
Contributor
|
I strongly suspect that the test checked for 2 issues because we were getting 2. We are generally deferring to you on what is expected for HED. Please feel free to update the expected number of issues in the test. cc @rwblair in case you remember something different. |
Since the "internal error" for the null pointer is no longer thrown, there is now only one issue for an invalid schema spec on this test.
Contributor
Author
|
I confirmed the second issue is from the null pointer, which is no longer generated. I've decreased the issue counts to 1. |
Member
|
Looks good. Everything we discussed has been addressed. |
effigies
approved these changes
Feb 12, 2025
effigies
added a commit
to effigies/bids-validator
that referenced
this pull request
Feb 14, 2025
rwblair
added a commit
that referenced
this pull request
Feb 14, 2025
doc: Add changelog entry for #160
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up various minor issues, and it should hopefully deal with the issues in #145 (though, as I couldn't reproduce the original issue, I couldn't test that).