Skip to content

Commit 9521c54

Browse files
chore: Sync BEP information with spec CITATION.cff (#698)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent adbdcfb commit 9521c54

File tree

2 files changed

+25
-19
lines changed

2 files changed

+25
-19
lines changed

data/beps/beps.yml

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@
132132
leads:
133133
- given-names: Eugene P.
134134
family-names: Duff
135-
136135
bids_maintainers:
137136
status:
138137
- specified different formats for dense and sparse matrices
@@ -181,8 +180,8 @@
181180
family-names: Hermes
182181
- given-names: Mainak
183182
family-names: Jas
184-
- given-names: Julia
185-
family-names: Guiomar Niso Galán
183+
- given-names: Guiomar
184+
family-names: Niso
186185
- given-names: Robert
187186
family-names: Oostenveld
188187
- given-names: Cyril
@@ -398,7 +397,7 @@
398397
content:
399398
- raw
400399
leads:
401-
- given-names: Eric
400+
- given-names: Eric A.
402401
family-names: Earl
403402
- given-names: Samuel
404403
family-names: Guay
@@ -407,7 +406,7 @@
407406
- given-names: Arshitha
408407
family-names: Basavaraj
409408
bids_maintainers:
410-
- given-names: Eric
409+
- given-names: Eric A.
411410
family-names: Earl
412411
status:
413412
- PR nearly ready to integrate with modality agnostic files sections.
@@ -455,7 +454,6 @@
455454
family-names: Herholz
456455
- given-names: Eugene P.
457456
family-names: Duff
458-
459457
- given-names: Anthony
460458
family-names: Galassi
461459
bids_maintainers:
@@ -503,7 +501,7 @@
503501
- given-names: Jean-Charles
504502
family-names: Mariani
505503
- given-names: Samuel
506-
family-names: Diebolt
504+
family-names: Le Meur-Diebolt
507505
- given-names: Thomas
508506
family-names: Deffieux
509507
bids_maintainers:
@@ -552,9 +550,9 @@
552550
family-names: Shirazi
553551
bids_maintainers:
554552
status:
555-
- Community comments and feedback are being collected (April 2025)
556-
- Approved on May 2024, inviting collaborators (please join)
557-
- Original issue: https://github.com/bids-standard/bids-specification/issues/1371
553+
- Community comments and feedback are being collected (April 2025)
554+
- Approved on May 2024, inviting collaborators (please join)
555+
- Original issue: https://github.com/bids-standard/bids-specification/issues/1371
558556
blocking:
559557
google_doc_created: 2023-01
560558
pull_request_created: 2024-12-06
@@ -641,7 +639,7 @@
641639
display: Tractography
642640
google_doc: https://docs.google.com/document/d/1ubDQ2RhgjnfGqoeukzEkPV9YEHhfYMERrj7-3b0c2HI/edit
643641
leads:
644-
- given-names: Robert
642+
- given-names: Robert E.
645643
family-names: Smith
646644
- given-names: Ariel
647645
family-names: Rokem

tools/ci/validate_people.py

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ def main(files_to_check):
3737

3838
for bep in data:
3939

40+
has_email = False
41+
4042
print(f'[blue]{bep["number"]} {bep["title"]}')
4143
for lead in bep["leads"]:
4244

@@ -57,24 +59,30 @@ def main(files_to_check):
5759
if status in ["not found", "skip"]:
5860
continue
5961

60-
if email["in_bids_wesbite"]:
62+
if email["in_bids_website"]:
6163
return_code = 1
6264
print(
63-
" [red]email should be in specification/CITATION.cff not in bids-wesbite data."
65+
" [red]email should be in specification/CITATION.cff not in bids-website data."
6466
)
6567

66-
if not email["in_citation_cff"]:
67-
return_code = 1
68-
print(" [red]no email in specification/CITATION.cff.")
68+
if email["in_citation_cff"]:
69+
has_email = True
70+
else:
71+
color = "yellow" if has_email else "red"
72+
print(
73+
f" [{color}]no email in specification/CITATION.cff."
74+
)
6975

7076
if email["conflicting"]:
7177
return_code = 1
7278
print(
7379
" [red]conflicting emails found:\n",
7480
f" [red] - '{email["in_citation_cff"]}' in specification/CITATION.cff\n"
75-
f" [red] - '{email["in_bids_wesbite"]}' bids-wesbite data.",
81+
f" [red] - '{email["in_bids_website"]}' bids-website data.",
7682
)
7783

84+
return_code |= not has_email
85+
7886
sys.exit(return_code)
7987

8088

@@ -83,7 +91,7 @@ def check_lead(citation, lead):
8391
status = "not found"
8492

8593
email = {
86-
"in_bids_wesbite": lead.get("email", False),
94+
"in_bids_website": lead.get("email", False),
8795
"in_citation_cff": False,
8896
"conflicting": False,
8997
}
@@ -99,7 +107,7 @@ def check_lead(citation, lead):
99107
email["in_citation_cff"] = contributor.get("email", False)
100108

101109
if (
102-
email["in_bids_wesbite"]
110+
email["in_bids_website"]
103111
and email["in_citation_cff"]
104112
and lead["email"] != contributor["email"]
105113
):

0 commit comments

Comments
 (0)