centralize converters #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remi-Gau
requested changes
Oct 11, 2024
Contributor
Remi-Gau
left a comment
Remi-Gau
left a comment
There was a problem hiding this comment.
Some minor changes required.
The most annoying would sorting the covnerters alphabetically. I think we can maybe add that as some sort of mini validation in another PR: so maybe tackle the easy things first and ping me when you are done with those.
bendhouseart
approved these changes
Oct 11, 2024
Contributor
bendhouseart
left a comment
bendhouseart
left a comment
There was a problem hiding this comment.
Agreeing with most of Remi's comments, but less particular about their execution happening now. LGTM
christinerogers
previously requested changes
Oct 17, 2024
Contributor
christinerogers
left a comment
christinerogers
left a comment
There was a problem hiding this comment.
looks fine, just spotted some changes that should be made on a tool. Damion can you please incorporate?
Co-authored-by: Remi Gau <[email protected]>
Co-authored-by: Remi Gau <[email protected]>
Co-authored-by: christinerogers <[email protected]>
Co-authored-by: christinerogers <[email protected]>
Co-authored-by: christinerogers <[email protected]>
…into 442-centralize-converters
Remi-Gau
approved these changes
Oct 17, 2024
Remi-Gau
reviewed
Oct 18, 2024
| - tools/converters/meeg.md | ||
| - tools/converters/physio.md | ||
| - tools/converters/others.md | ||
| - tools/converters.md |
Contributor
There was a problem hiding this comment.
This the main change.
The rest is "cosmetic".
Contributor
|
seems that our markdown linting does not raise warnings as error will fix in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will (eventually) close #442
Would like feedback on this draft, please.
Also, unsure why the subfile/subpages (eg converters/eeg.md) left behind "unknown" entries in the table of contents when deleted. How do I clear those table of contents entries. Ideas? @Remi-Gau @bendhouseart ?