Skip to content

Commit 5053402

Browse files
committed
Ensure TSV checks use strings for Issue evidence.
1 parent f541ca6 commit 5053402

File tree

1 file changed

+13
-7
lines changed
  • bids-validator/validators/tsv

1 file changed

+13
-7
lines changed

bids-validator/validators/tsv/tsv.js

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,17 @@
11
import utils from '../../utils'
2-
const Issue = utils.issues.Issue
2+
import Issue from '../../utils/issues/issue'
33
import checkAcqTimeFormat from './checkAcqTimeFormat'
44
import checkAge89 from './checkAge89'
55
import checkStatusCol from './checkStatusCol'
66
import parseTSV from './tsvParser'
77

8+
/**
9+
* Format TSV headers for evidence string
10+
* @param {Array[string]} headers
11+
* @returns {string}
12+
*/
13+
const headersEvidence = headers => `Column headers: ${headers.join(', ')}`
14+
815
/**
916
* TSV
1017
*
@@ -98,7 +105,7 @@ const TSV = (file, contents, fileList, callback) => {
98105
issues.push(
99106
new Issue({
100107
file: file,
101-
evidence: headers,
108+
evidence: headersEvidence(headers),
102109
line: 1,
103110
character: rows[0].indexOf(headers[idx]),
104111
code: code,
@@ -113,7 +120,7 @@ const TSV = (file, contents, fileList, callback) => {
113120
issues.push(
114121
new Issue({
115122
file: file,
116-
evidence: headers,
123+
evidence: headersEvidence(headers),
117124
line: 1,
118125
code: 20,
119126
}),
@@ -123,7 +130,7 @@ const TSV = (file, contents, fileList, callback) => {
123130
issues.push(
124131
new Issue({
125132
file: file,
126-
evidence: headers,
133+
evidence: headersEvidence(headers),
127134
line: 1,
128135
code: 21,
129136
}),
@@ -181,7 +188,7 @@ const TSV = (file, contents, fileList, callback) => {
181188
issues.push(
182189
new Issue({
183190
file: file,
184-
evidence: headers.join('\t'),
191+
evidence: headersEvidence(headers),
185192
line: 1,
186193
code: 48,
187194
}),
@@ -287,7 +294,6 @@ const TSV = (file, contents, fileList, callback) => {
287294
if (file.name === 'participants.tsv') {
288295
checkAge89(rows, file, issues)
289296
}
290-
291297

292298
if (file.name.endsWith('_scans.tsv')) {
293299
// check _scans.tsv for column filename
@@ -296,7 +302,7 @@ const TSV = (file, contents, fileList, callback) => {
296302
new Issue({
297303
line: 1,
298304
file: file,
299-
evidence: headers.join('\t'),
305+
evidence: headersEvidence(headers),
300306
code: 68,
301307
}),
302308
)

0 commit comments

Comments
 (0)