Skip to content

Commit 7bd54b4

Browse files
authored
Merge pull request #434 from chrisfilo/enh/cr_test
Test for CR new lines
2 parents 17caae2 + 79dc0c8 commit 7bd54b4

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

utils/issues/list.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -346,5 +346,10 @@ module.exports = {
346346
key: 'FILENAME_COLUMN',
347347
severity: 'error',
348348
reason: "_scans.tsv files must have a 'filename' column."
349+
},
350+
69: {
351+
key: 'WRONG_NEW_LINE',
352+
severity: 'error',
353+
reason: "All TSV files must use Line Feed '\\n' characters to denote new lines. This files uses Carriage Return '\\r'."
349354
}
350355
};

validators/tsv.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,16 @@ var utils = require('../utils');
1414
var TSV = function TSV (file, contents, fileList, callback) {
1515

1616
var issues = [];
17+
if ((contents.includes('\r')) && (!contents.includes('\n'))) {
18+
issues.push(new Issue({
19+
file: file,
20+
evidence: contents,
21+
code: 69
22+
}));
23+
callback(issues, null);
24+
return;
25+
}
26+
1727
var rows = contents.split('\n');
1828
var headers = rows[0].split('\t');
1929

0 commit comments

Comments
 (0)