Skip to content

Commit d7a00cc

Browse files
authored
Merge pull request #662 from olgn/fix-child-process-call
Fix browser webpack build errors
2 parents 5ec76dd + 5f37ce6 commit d7a00cc

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

package.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,5 +67,9 @@
6767
},
6868
"jest": {
6969
"testEnvironment": "node"
70+
},
71+
"browser": {
72+
"fs": false,
73+
"child_process": false
7074
}
7175
}

utils/files/remoteFiles.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
const AWS = require('aws-sdk')
22
const fs = require('fs')
3-
const { execSync } = require('child_process')
3+
const cp = require('child_process')
44
const Issue = require('../issues').Issue
55
const zlib = require('zlib')
66
const s3 = new AWS.S3()
@@ -141,7 +141,7 @@ const remoteFiles = {
141141

142142
// Function for calling local git-annex
143143
callGitAnnex: function(cmd, cwd) {
144-
const stream = execSync(cmd, {
144+
const stream = cp.execSync(cmd, {
145145
shell: true,
146146
cwd,
147147
})

validators/tsv/checkAcqTimeFormat.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
const Issue = require('../../utils').issues.Issue
2-
const dateIsValid = require('date-fns/isValid')
3-
const parseDate = require('date-fns/parse')
2+
const df = require('date-fns')
43

54
const checkAcqTimeFormat = function(rows, file, issues) {
65
const format = "yyyy-MM-dd'T'HH:mm:ss"
@@ -10,7 +9,7 @@ const checkAcqTimeFormat = function(rows, file, issues) {
109
testRows.map((line, i) => {
1110
const lineValues = line.trim().split('\t')
1211
const acqTime = lineValues[acqTimeColumn]
13-
let isValid = dateIsValid(parseDate(acqTime, format, new Date()))
12+
let isValid = df.isValid(df.parse(acqTime, format, new Date()))
1413
if (acqTime === 'n/a') {
1514
isValid = true
1615
}

0 commit comments

Comments
 (0)