Skip to content

Commit e0ada04

Browse files
authored
Merge pull request #2117 from effigies/examples
chore(ci): Ignore MRS examples for legacy validator
2 parents 2a86a83 + 0b413f7 commit e0ada04

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

.github/workflows/test-bids-examples.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,12 @@ jobs:
5757
which bids-validator
5858
ls -a $(which bids-validator)
5959
60+
- name: Ignore examples not supported by legacy validator
61+
run: |
62+
for DS in bids-examples/mrs_*; do
63+
touch $DS/.SKIP_VALIDATION
64+
done
65+
6066
- name: Validate all BIDS datasets using bids-validator
6167
run: |
6268
export PATH="../node_modules/.bin:$PATH"

bids-validator/tests/bids.spec.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,9 @@ describe('BIDS example datasets ', function () {
106106
assert(summary.subjects.length === 16)
107107
assert.deepEqual(summary.tasks, ['balloon analog risk task'])
108108
expect(summary.modalities).toEqual(['MRI'])
109-
assert(summary.totalFiles === 134)
109+
assert(summary.totalFiles === 135)
110110
assert.deepEqual(errors.length, 1)
111-
assert(warnings.length === 2)
111+
assert(warnings.length === 3)
112112
assert(
113113
warnings.findIndex((warning) => warning.code === 13) > -1,
114114
'warnings do not contain a code 13',
@@ -217,9 +217,9 @@ describe('BIDS example datasets ', function () {
217217
assert(summary.subjects.length === 16)
218218
assert.deepEqual(summary.tasks, ['balloon analog risk task'])
219219
assert(summary.modalities.includes('MRI'))
220-
assert(summary.totalFiles === 134)
220+
assert(summary.totalFiles === 135)
221221
assert.deepEqual(errors.length, 1)
222-
assert(warnings.length === 2)
222+
assert(warnings.length === 3)
223223
assert(
224224
warnings.findIndex((warning) => warning.code === 13) > -1,
225225
'warnings do not contain a code 13',
@@ -241,9 +241,9 @@ describe('BIDS example datasets ', function () {
241241
assert(summary.subjects.length === 16)
242242
assert.deepEqual(summary.tasks, ['balloon analog risk task'])
243243
assert(summary.modalities.includes('MRI'))
244-
assert(summary.totalFiles === 134)
244+
assert(summary.totalFiles === 135)
245245
assert.deepEqual(errors.length, 2)
246-
assert(warnings.length === 2)
246+
assert(warnings.length === 3)
247247
assert(
248248
warnings.findIndex((warning) => warning.code === 13) > -1,
249249
'warnings do not contain a code 13',
Submodule bids-examples updated 439 files

0 commit comments

Comments
 (0)