-
Notifications
You must be signed in to change notification settings - Fork 106
Fixes to allow Deno check to pass and build to succeed. #2161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 3 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
9d18828
add further type checks to catching errors, and then immediately ts-i…
rwblair cbe29a7
bump github workflows to use deno v2
rwblair 0c4088e
do we really need to specify --node-modules-dir=auto for these deno c…
rwblair ff37b3a
allow-env during build step.
rwblair 15ebfce
why does installing std library require special permissions?
rwblair 8877ba6
build needs to run git, set --allow-run
rwblair e6aea46
should of just -A'd it eh?
rwblair 0af7d7e
Update .github/workflows/deno_tests.yml
effigies a174a76
specify default import from ajv in validators/json.ts imports
rwblair d941cf6
Merge branch 'fix/deno_2_test_and_build' of github.com:rwblair/bids-v…
rwblair b67e28f
revert ajv import bump version. Deno may be installing from package.j…
rwblair dde7007
bump ajv in package.json. Will this break legacy?
rwblair 0b88900
Revert "bump ajv in package.json. Will this break legacy?"
rwblair fd86b31
move legacy validator to its own directory.
rwblair 3ac00ad
working-dir -> working-directory
rwblair 3331f80
more working-directory setting. fix sym link from legacy test to curr…
rwblair d3258d2
more working-directory setting. fix sym link from legacy test to curr…
rwblair c9ed50c
in progress README updates
rwblair 064fea7
Merge branch 'master' of github.com:bids-standard/bids-validator into…
rwblair c87f70c
set working directory for circleci
rwblair e9e919c
Merge branch 'fix/deno_2_test_and_build' of github.com:rwblair/bids-v…
rwblair 10044b7
deno loader back to version 11
rwblair efbbc77
amend circle cache paths, they may not respect working-directory
rwblair bc6afbb
working-directory -> working_directory
rwblair 8f4fd8f
fix call to get local version
rwblair 25c4bb3
remove circleci config
rwblair 0c3f8a8
first pass at deno dockerfile. Update docker github workflow accordin…
rwblair 5f75b1e
Revert "remove circleci config"
rwblair 6923b6f
Move dockerfile to base. Deno cli now handles git not existing.
rwblair File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| ARG BASE_IMAGE=denoland/deno:2.0.1 | ||
| FROM ${BASE_IMAGE} AS base | ||
| WORKDIR /src | ||
|
|
||
| RUN apt-get update && \ | ||
| apt-get install -y git && \ | ||
| apt-get clean && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| COPY . . | ||
| RUN deno cache ./bids-validator-deno | ||
| RUN ./build.ts | ||
|
|
||
| ENTRYPOINT ["./bids-validator-deno"] | ||
|
|
||
| FROM ${BASE_IMAGE} AS min | ||
| WORKDIR /src | ||
| COPY --from=base /src/dist/validator/* . | ||
|
|
||
| ENTRYPOINT ["deno", "-A", "./bids-validator.js"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.