fix(src): linter errors (flare-foundation#102)

Author: dineshpinto

examples/02_ingest_pdf.py

@@ -6,7 +6,6 @@
 """
 
 import asyncio
-from pathlib import Path
 from unittest.mock import AsyncMock, mock_open, patch
 
 from data.create_sample_invoice import create_invoice_and_get_coords
@@ -62,7 +61,7 @@ async def main() -> None:
                 "use_ocr": False,
                 "contract_settings": {
                     "contract_address": "0x0000000000000000000000000000000000000000",
-                    "abi_path": Path(__file__),
+                    "abi_name": "OnchainDataRegistry",
                     "function_name": "registerDocument",
                 },
             }

examples/03_turnkey_wallet_integration.py

@@ -91,13 +91,12 @@ async def create_demo_wallet(wallet: TurnkeyWallet) -> tuple[str, str]:
         address_info = await wallet.get_address(wallet_id)
         print(f"📍 Wallet address: {address_info.address}")
         print(f"📍 Derivation path: {address_info.derivation_path}")
-
-        return wallet_id, address_info.address
-
     except Exception as e:
         print(f"❌ Failed to create wallet: {e}")
         # For demo purposes, return mock values
         return "demo_wallet_id", "0x742d35Cc6634C0532925a3b8D8C8EE7c9e92bb1b"
+    else:
+        return wallet_id, address_info.address
 
 
 async def register_ai_agent(
@@ -148,12 +147,12 @@ async def simulate_tee_operation(_tee_manager: TEESecurityManager) -> str:
         # In production, this would create a secure operation
 
         print("✅ TEE operation simulated (would validate in production)")
-        return mock_attestation_token
-
     except Exception as e:
         print(f"❌ TEE operation failed: {e}")
         print("   Using mock attestation for demo purposes")
         return mock_attestation_token
+    else:
+        return mock_attestation_token
 
 
 async def execute_ai_transaction(
@@ -202,12 +201,11 @@ async def execute_ai_transaction(
             print(f"   📋 Signed transaction: {result['signed_transaction'][:50]}...")
         else:
             print(f"❌ Transaction failed: {result['error']}")
-
-        return result
-
     except Exception as e:
         print(f"❌ Transaction execution error: {e}")
         return {"success": False, "error": str(e)}
+    else:
+        return result
 
 
 async def demonstrate_policy_enforcement(

examples/data/sample_invoice.pdf

@@ -102,7 +102,8 @@ select = ["ALL"]
 ignore = ["D203", "D212", "COM812", "S105", "D401", "D104", "ANN401", "ISC003", "D107", "FBT001", "FBT002", "FBT003"]
 
 [tool.ruff.lint.extend-per-file-ignores]
-"tests/**/*.py" = ["S101", "ARG", "PLR2004", "SLF001", "BLE001", "E501", "T201", "D", "ANN001", "ANN201", "F821"]
+"ecosystem_tools_wrapper.py" = ["PLC0415"]
+"tests/**/*.py" = ["S", "ARG", "PLR2004", "SLF001", "BLE001", "E501", "T201", "D", "ANN", "F821", "PLC"]
 "examples/**/*.py" = ["T201", "BLE001", "D415", "D100", "INP001"]
 
 [tool.pyright]

pyproject.toml

@@ -1,6 +1,6 @@
 # flare_ai_kit/adk/__init__.py
 
-from ..tool import tool  # pyright: ignore[reportUnknownvariableType]
+from flare_ai_kit.agent.tool import tool  # pyright: ignore[reportUnknownvariableType]
 
 # This exposes `adk.tool` to users who import `adk`
 __all__ = ["tool"]

src/flare_ai_kit/agent/adk/__init__.py

@@ -1,4 +1,5 @@
-# agent/adk_agent.py
+"""Based ADK Agent using all tools."""
+
 from google.adk.agents import Agent
 
 from flare_ai_kit.agent.settings import AgentSettings

src/flare_ai_kit/agent/adk_agent.py

@@ -1,3 +1,5 @@
+"""Wrapper for Google ADK ecosystem tools."""
+
 from eth_typing import ChecksumAddress
 from httpx import HTTPStatusError, RequestError, TimeoutException
 from web3.contract.async_contract import AsyncContractFunction
@@ -11,9 +13,7 @@
 
 @adk.tool
 async def check_balance(address: str) -> float:
-    """
-    Check the balance of a given Flare address in FLR.
-    """
+    """Check FLR balance of a given address."""
     from flare_ai_kit.ecosystem.flare import Flare
     from flare_ai_kit.ecosystem.settings import EcosystemSettings
 
@@ -130,7 +130,8 @@ async def get_ftso_latest_price(feed_name: str) -> float:
     settings = EcosystemSettings()
     ftso = await FtsoV2.create(settings)
     if not ftso:
-        raise ValueError("FtsoV2 instance not fully initialized. Use FtsoV2.create().")
+        msg = "FtsoV2 instance not fully initialized. Use FtsoV2.create()."
+        raise ValueError(msg)
 
     return await ftso.get_latest_price(feed_name)
 
@@ -159,7 +160,8 @@ async def get_ftso_latest_prices(feed_names: list[str]) -> list[float]:
     settings = EcosystemSettings()
     ftso = await FtsoV2.create(settings)
     if not ftso:
-        raise ValueError("FtsoV2 instance not fully initialized. Use FtsoV2.create().")
+        msg = "FtsoV2 instance not fully initialized. Use FtsoV2.create()."
+        raise ValueError(msg)
 
     return await ftso.get_latest_prices(feed_names)
 
@@ -193,9 +195,11 @@ async def get_contract_abi(contract_address: str) -> list[dict[str, str]]:
         async with explorer:
             return await explorer.get_contract_abi(contract_address)
     except (HTTPStatusError, RequestError, TimeoutException) as e:
-        raise ExplorerError(f"Failed to fetch contract ABI: {e}")
+        msg = f"Failed to fetch contract ABI: {e}"
+        raise ExplorerError(msg) from e
     except AbiError as e:
-        raise ValueError(f"Invalid ABI response for contract {contract_address}: {e}")
+        msg = f"Invalid ABI response for contract {contract_address}: {e}"
+        raise ValueError(msg) from e
 
 
 # --- Social: X (Twitter) ---
@@ -210,9 +214,8 @@ async def post_to_x(content: str) -> bool:
     settings = SocialSettings()  # type: ignore[call-arg]
     x_client = XClient(settings)
     if not x_client.is_configured:
-        raise ValueError(
-            "XClient is not configured. Ensure API keys are set in the environment."
-        )
+        msg = "XClient is not configured. Ensure API keys are set."
+        raise ValueError(msg)
 
     return await x_client.post_tweet(content)
 
@@ -230,7 +233,7 @@ async def send_telegram_message(chat_id: str, message: str) -> bool:
     Args:
         chat_id: The unique identifier for the target chat
             (e.g., '@channelname' or a user ID).
-        text: The text of the message to send.
+        message: The text of the message to send.
 
     Returns:
         True if the message was sent successfully, False otherwise.
@@ -242,8 +245,7 @@ async def send_telegram_message(chat_id: str, message: str) -> bool:
     settings = SocialSettings()  # type: ignore[call-arg]
     telegram_client = TelegramClient(settings)
     if not telegram_client.is_configured:
-        raise ValueError(
-            "TelegramClient is not configured. Ensure API token is set in the environment."
-        )
+        msg = "TelegramClient is not configured. Ensure API keys are set."
+        raise ValueError(msg)
 
     return await telegram_client.send_message(chat_id, message)

src/flare_ai_kit/agent/ecosystem_tools_wrapper.py

@@ -1,26 +1,32 @@
+"""Generic for ADK tool."""
+
 import inspect
 from collections.abc import Callable
 from functools import wraps
 from typing import Any, TypeVar, cast
 
+import structlog
 from google.adk.tools import FunctionTool, LongRunningFunctionTool
 
+logger = structlog.get_logger(__name__)
+
+
 RT = TypeVar("RT")  # Return type
-# ToolUnion = FunctionTool
 TOOL_REGISTRY: list[Any] = []
 
 
-def tool(func: Callable[..., RT]) -> Callable[..., RT]:
+def tool(func: Callable[..., RT]) -> Callable[..., RT]:  # noqa: UP047
     """
     Decorator to register a function as a Gemini-compatible ADK tool.
+
     Automatically wraps async functions using LongRunningFunctionTool,
     and sync functions using FunctionTool.
     """
     is_async = inspect.iscoroutinefunction(func)
 
     @wraps(func)
     def wrapper(*args: Any, **kwargs: Any) -> Any:
-        print(f"[ADK TOOL] Calling {func.__name__} with args={args}, kwargs={kwargs}")
+        logger.info("adk_tool", func=func.__name__, args=args, kwargs=kwargs)
         return func(*args, **kwargs)
 
     # Choose appropriate wrapper

src/flare_ai_kit/agent/tool.py

@@ -139,7 +139,7 @@ async def unregister_agent(self, agent_id: str) -> bool:
         logger.info("AI agent unregistered successfully", agent_id=agent_id)
         return True
 
-    async def execute_agent_transaction(
+    async def execute_agent_transaction(  # noqa: PLR0911
         self,
         agent_transaction: AgentTransaction,
         attestation_token: str | None = None,

src/flare_ai_kit/agents/turnkey.py

@@ -1,6 +1,6 @@
 """Settings for Vector RAG."""
 
-from pydantic import Field, FilePath, PositiveInt, model_validator
+from pydantic import Field, PositiveInt, model_validator
 from pydantic_settings import BaseSettings, SettingsConfigDict
 
 DEFAULT_ALLOWED_EXTENSIONS = {
@@ -89,8 +89,8 @@ class OnchainContractSettings(BaseSettings):
     contract_address: str = Field(
         description="The address of the OnchainDataRegistry smart contract."
     )
-    abi_path: FilePath = Field(
-        description="The path to the ABI file for the smart contract."
+    abi_name: str = Field(
+        description="ABI file name for the smart contract (under flare-ai-kit/abi/)."
     )
     function_name: str = Field(
         "registerDocument",