Skip to content

Conversation

@soorajbhaskaran
Copy link
Contributor

@soorajbhaskaran soorajbhaskaran commented Jul 15, 2024

Fixes #22

Description

  • Added a new prop as the 4th argument which can be used to pass the external document object of the iframe
  • Updated the readme with change

Checklist

  • I have made corresponding changes to the documentation.
  • I have verified the functionality in a React application.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers
@soorajbhaskaran _a

@soorajbhaskaran
Copy link
Contributor Author

@josephmathew900 _a: Please review

Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephmathew900 josephmathew900 merged commit 0760fdf into main Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to use the "useHotkeys" hook inside an iframe

3 participants