Skip to content

Added spec for t.remove with multiple column names #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Added spec for t.remove with multiple column names #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions spec/rubocop/cop/neeto/unsafe_column_deletion_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,18 @@ def down
expect_no_offenses(snippet)
end

it "registers an offense when multiple columns are dropped in a single remove operation" do
snippet = <<~RUBY
change_table :users do |t|
t.remove :email, :first_name
^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{offense("users", "email", true)}
t.string :last_name, type: :string
end
RUBY

expect_offense(snippet)
end

private

def offense(table_name, column_name, change_table = false)
Expand Down