|
| 1 | +--- |
| 2 | +"@bigcommerce/catalyst-core": patch |
| 3 | +--- |
| 4 | + |
| 5 | +Fix WishlistDetails page from exceeding GraphQL complexity limit, and fix wishlist e2e tests |
| 6 | + |
| 7 | +## Migration |
| 8 | + |
| 9 | +### Step 1: Update wishlist GraphQL fragments |
| 10 | + |
| 11 | +In `core/components/wishlist/fragment.ts`, replace the `WishlistItemProductFragment` to use explicit fields instead of `ProductCardFragment`: |
| 12 | + |
| 13 | +```typescript |
| 14 | +export const WishlistItemProductFragment = graphql( |
| 15 | + ` |
| 16 | + fragment WishlistItemProductFragment on Product { |
| 17 | + entityId |
| 18 | + name |
| 19 | + defaultImage { |
| 20 | + altText |
| 21 | + url: urlTemplate(lossy: true) |
| 22 | + } |
| 23 | + path |
| 24 | + brand { |
| 25 | + name |
| 26 | + path |
| 27 | + } |
| 28 | + reviewSummary { |
| 29 | + numberOfReviews |
| 30 | + averageRating |
| 31 | + } |
| 32 | + sku |
| 33 | + showCartAction |
| 34 | + inventory { |
| 35 | + isInStock |
| 36 | + } |
| 37 | + availabilityV2 { |
| 38 | + status |
| 39 | + } |
| 40 | + ...PricingFragment |
| 41 | + } |
| 42 | + `, |
| 43 | + [PricingFragment], |
| 44 | +); |
| 45 | +``` |
| 46 | + |
| 47 | +Remove `ProductCardFragment` from all fragment dependencies in the same file. |
| 48 | + |
| 49 | +### Step 2: Update product card transformer |
| 50 | + |
| 51 | +In `core/data-transformers/product-card-transformer.ts`: |
| 52 | + |
| 53 | +1. Import the `WishlistItemProductFragment`: |
| 54 | + ```typescript |
| 55 | + import { WishlistItemProductFragment } from '~/components/wishlist/fragment'; |
| 56 | + ``` |
| 57 | + |
| 58 | +2. Update the `singleProductCardTransformer` function signature to accept both fragment types: |
| 59 | + ```typescript |
| 60 | + product: ResultOf<typeof ProductCardFragment | typeof WishlistItemProductFragment> |
| 61 | + ``` |
| 62 | + |
| 63 | +3. Add a conditional check for the `inventoryMessage` field: |
| 64 | + ```typescript |
| 65 | + inventoryMessage: |
| 66 | + 'variants' in product |
| 67 | + ? getInventoryMessage(product, outOfStockMessage, showBackorderMessage) |
| 68 | + : undefined, |
| 69 | + ``` |
| 70 | + |
| 71 | +4. Update the `productCardTransformer` function signature similarly: |
| 72 | + ```typescript |
| 73 | + products: Array<ResultOf<typeof ProductCardFragment | typeof WishlistItemProductFragment>> |
| 74 | + ``` |
| 75 | + |
| 76 | +### Step 3: Fix wishlist e2e tests |
| 77 | + |
| 78 | +In `core/tests/ui/e2e/account/wishlists.spec.ts`, update label selectors to use `{ exact: true }` for specificity: |
| 79 | + |
| 80 | +Update all locators for the wishlist name input selectors: |
| 81 | + ```diff |
| 82 | + - page.getByLabel(t('Form.nameLabel')) |
| 83 | + + page.getByLabel(t('Form.nameLabel'), { exact: true }) |
| 84 | + ``` |
| 85 | + |
| 86 | +### Step 4: Fix mobile wishlist e2e tests |
| 87 | + |
| 88 | +In `core/tests/ui/e2e/account/wishlists.mobile.spec.ts`, update translation calls to use namespace prefixes: |
| 89 | + |
| 90 | +1. Update the translation initialization: |
| 91 | + ```diff |
| 92 | + - const t = await getTranslations('Account.Wishlist'); |
| 93 | + + const t = await getTranslations(); |
| 94 | + ``` |
| 95 | + |
| 96 | +2. Update all translation keys to include the namespace: |
| 97 | + ```diff |
| 98 | + - await locator.getByRole('button', { name: t('actionsTitle') }).click(); |
| 99 | + - await page.getByRole('menuitem', { name: t('share') }).click(); |
| 100 | + + await locator.getByRole('button', { name: t('Wishlist.actionsTitle') }).click(); |
| 101 | + + await page.getByRole('menuitem', { name: t('Wishlist.share') }).click(); |
| 102 | + ``` |
| 103 | + |
| 104 | + ```diff |
| 105 | + - await expect(page.getByText(t('shareSuccess'))).toBeVisible(); |
| 106 | + + await expect(page.getByText(t('Wishlist.shareSuccess'))).toBeVisible(); |
| 107 | + ``` |
| 108 | + |
0 commit comments