Skip to content

Commit 854cdfc

Browse files
fix(storefront): Prevent flow outside page container on account pages (#2462)
* Add account-content wrapper so content doesn't flow outside page container * Update changelog * Remove newline --------- Co-authored-by: Volodymyr Krasnoshapka <88093058+BC-krasnoshapka@users.noreply.github.com>
1 parent 7b738c0 commit 854cdfc

3 files changed

Lines changed: 23 additions & 20 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

77
## Draft
8+
- Prevent flow outside page container on account pages [#2462](https://github.com/bigcommerce/cornerstone/pull/2462)
89
- Account.js - Fixed jquery selector to be template literal [#2464](https://github.com/bigcommerce/cornerstone/pull/2464)
910

1011
## 6.14.0 (05-15-2024)

templates/pages/account/add-address.html

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -17,26 +17,26 @@ <h2 class="page-heading">{{lang 'forms.address.add.heading'}}</h2>
1717
{{/if}}
1818

1919
<div class="account-body">
20-
21-
<form action="{{forms.address.action}}" data-address-form class="form" method="post">
22-
{{#if forms.address.address_id }}
23-
<input type="hidden" name="shipid" value="{{forms.address.address_id}}">
24-
{{/if}}
25-
<fieldset class="form-fieldset">
26-
<div class="form-row form-row--half">
27-
{{#each forms.address.shipping_fields }}
28-
{{{dynamicComponent 'components/common/forms'}}}
29-
{{/each}}
20+
<section class="account-content">
21+
<form action="{{forms.address.action}}" data-address-form class="form" method="post">
22+
{{#if forms.address.address_id }}
23+
<input type="hidden" name="shipid" value="{{forms.address.address_id}}">
24+
{{/if}}
25+
<fieldset class="form-fieldset">
26+
<div class="form-row form-row--half">
27+
{{#each forms.address.shipping_fields }}
28+
{{{dynamicComponent 'components/common/forms'}}}
29+
{{/each}}
30+
</div>
31+
</fieldset>
32+
<div class="form-actions">
33+
<input type="submit" class="button button--primary" value="{{lang 'forms.address.submit_value'}}">
34+
<a href="{{urls.account.addresses}}" class="button">{{lang 'common.cancel'}}</a>
35+
{{inject 'required' (lang 'common.required')}}
36+
{{inject 'state_error' (lang 'errors.state_error')}}
3037
</div>
31-
</fieldset>
32-
<div class="form-actions">
33-
<input type="submit" class="button button--primary" value="{{lang 'forms.address.submit_value'}}">
34-
<a href="{{urls.account.addresses}}" class="button">{{lang 'common.cancel'}}</a>
35-
{{inject 'required' (lang 'common.required')}}
36-
{{inject 'state_error' (lang 'errors.state_error')}}
37-
</div>
38-
</form>
39-
38+
</form>
39+
</section>
4040
</div>
4141
</div>
4242

templates/pages/account/addresses.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ <h2 class="page-heading">{{lang 'account.addresses.heading' }}</h2>
1111
{{#if customer.success}}
1212
{{>components/common/alert/alert-success customer.success}}
1313
{{/if}}
14-
{{> components/account/address-list }}
14+
<section class="account-content">
15+
{{> components/account/address-list }}
16+
</section>
1517
</div>
1618
</div>
1719
{{/partial}}

0 commit comments

Comments
 (0)