Merge pull request #108 from deini/eslint-8

Bump eslint to v8 and all plugins

Author: deini

.circleci/config.yml

@@ -1,34 +1,48 @@
 version: 2.1
 orbs:
-  node: circleci/node@1.1.4
+  node: circleci/node@4.7.0
 
 default_executor: &default_executor
   executor:
     name: node/default
-    tag: '14.16'
+    tag: '14.17'
 
 commands:
   install-dependencies:
+    parameters:
+      cache-version:
+        type: string
+        default: v1
+        description: Change the cache version if you need to clear the cache for any reason.
+
     steps:
       - node/install-yarn:
           version: 1.22.10
 
-      - node/with-cache:
-          cache-key: yarn.lock
-          cache-version: v1
-          include-branch-in-cache-key: false
-          steps:
-            - run:
-                name: yarn install
-                command: |
-                  CKSUM_BEFORE=$(cksum yarn.lock)
-                  yarn install
-                  CKSUM_AFTER=$(cksum yarn.lock)
-
-                  if [[ $CKSUM_BEFORE != $CKSUM_AFTER ]]; then
-                    echo "yarn.lock was modified unexpectedly - terminating"
-                    exit 1
-                  fi
+      - restore_cache:
+          keys:
+            - node-deps-<<parameters.cache-version>>-{{ checksum "package.json" }}-{{ checksum "yarn.lock" }}
+            - node-deps-<<parameters.cache-version>>-{{ checksum "package.json" }}
+            - node-deps-<<parameters.cache-version>>
+
+      - run:
+          name: yarn install
+          command: |
+              CKSUM_BEFORE=$(cksum yarn.lock)
+              yarn install
+              CKSUM_AFTER=$(cksum yarn.lock)
+            
+              if [[ $CKSUM_BEFORE != $CKSUM_AFTER ]]; then
+                echo "yarn.lock was modified unexpectedly - terminating"
+                exit 1
+              fi
+      
+      - save_cache:
+          key: node-deps-<<parameters.cache-version>>-{{ checksum "package.json" }}-{{ checksum "yarn.lock" }}
+          paths:
+            - node_modules
+            - packages/eslint-config/node_modules
+            - packages/eslint-plugin/node_modules
 
 jobs:
   test:

export_maps_resolver.js

@@ -0,0 +1,12 @@
+// temporary workaround while we wait for https://github.com/facebook/jest/issues/9771
+const enhancedResolve = require('enhanced-resolve');
+
+const resolver = enhancedResolve.create.sync({
+  conditionNames: ['require', 'node', 'default'],
+  extensions: ['.js', '.json'],
+  mainFields: ['exports', 'main', 'require'],
+});
+
+module.exports = (request, options) => {
+  return resolver(options.basedir, request);
+};

jest.config.js

@@ -0,0 +1,3 @@
+module.exports = {
+  resolver: './export_maps_resolver.js',
+};

package.json

@@ -21,9 +21,11 @@
   },
   "devDependencies": {
     "@bigcommerce/validate-commits": "^2.0.2",
-    "eslint": "^7.26.0",
-    "jest": "^27.0.4",
+    "enhanced-resolve": "^5.8.3",
+    "eslint": "^8.1.0",
+    "jest": "^27.3.1",
     "lerna": "^4.0.0",
-    "typescript": "^4.2.4"
-  }
+    "typescript": "^4.4.4"
+  },
+  "dependencies": {}
 }

packages/eslint-config/configs/typescript.js

@@ -109,6 +109,34 @@ module.exports = {
     ],
     '@typescript-eslint/no-use-before-define': ['error', 'nofunc'],
     '@typescript-eslint/no-useless-constructor': 'error',
+    '@typescript-eslint/padding-line-between-statements': [
+      'warn',
+      {
+        blankLine: 'always',
+        next: 'return',
+        prev: '*',
+      },
+      {
+        blankLine: 'always',
+        next: ['block', 'block-like', 'class', 'const', 'let', 'var', 'interface'],
+        prev: '*',
+      },
+      {
+        blankLine: 'always',
+        next: '*',
+        prev: ['block', 'block-like', 'class', 'const', 'let', 'var', 'interface'],
+      },
+      {
+        blankLine: 'any',
+        next: ['const', 'let', 'var'],
+        prev: ['const', 'let', 'var'],
+      },
+      {
+        blankLine: 'any',
+        next: ['case'],
+        prev: ['case'],
+      },
+    ],
     '@typescript-eslint/prefer-for-of': 'error',
     '@typescript-eslint/prefer-function-type': 'error',
     '@typescript-eslint/require-await': 'error',
@@ -128,6 +156,7 @@ module.exports = {
     'no-unused-vars': 'off',
     'no-use-before-define': 'off',
     'no-useless-constructor': 'off',
+    'padding-line-between-statements': 'off',
     'sort-keys': 'off',
   },
   settings: {

packages/eslint-config/package.json

@@ -21,28 +21,28 @@
   },
   "dependencies": {
     "@bigcommerce/eslint-plugin": "^1.0.0",
-    "@rushstack/eslint-patch": "^1.0.6",
-    "@typescript-eslint/eslint-plugin": "^4.22.0",
-    "@typescript-eslint/parser": "^4.22.0",
+    "@rushstack/eslint-patch": "^1.0.9",
+    "@typescript-eslint/eslint-plugin": "^5.2.0",
+    "@typescript-eslint/parser": "^5.2.0",
     "eslint-config-prettier": "^8.3.0",
-    "eslint-import-resolver-typescript": "^2.4.0",
-    "eslint-plugin-gettext": "^1.1.0",
-    "eslint-plugin-import": "^2.22.1",
-    "eslint-plugin-jest": "^24.3.6",
+    "eslint-import-resolver-typescript": "^2.5.0",
+    "eslint-plugin-gettext": "^1.2.0",
+    "eslint-plugin-import": "^2.25.2",
+    "eslint-plugin-jest": "^25.2.2",
     "eslint-plugin-jest-formatting": "^3.0.0",
-    "eslint-plugin-jsdoc": "^35.1.2",
+    "eslint-plugin-jsdoc": "^37.0.3",
     "eslint-plugin-jsx-a11y": "^6.4.1",
-    "eslint-plugin-prettier": "^3.4.0",
-    "eslint-plugin-react": "^7.23.2",
+    "eslint-plugin-prettier": "^4.0.0",
+    "eslint-plugin-react": "^7.26.1",
     "eslint-plugin-react-hooks": "^4.2.0",
     "eslint-plugin-switch-case": "^1.1.2",
-    "prettier": "^2.2.1"
+    "prettier": "^2.4.1"
   },
   "devDependencies": {
     "react": "^17.0.2"
   },
   "peerDependencies": {
-    "eslint": "^7.0.0",
+    "eslint": "^8.0.0",
     "typescript": "^4.0.0"
   },
   "peerDependenciesMeta": {