Skip to content

Commit 01d8905

Browse files
authored
Merge pull request #47 from bigcommerce/envoy_te_header
Add TE header for envoy requests
2 parents c11c002 + 55ecb85 commit 01d8905

3 files changed

Lines changed: 6 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ Changelog for grphp.
22

33
### Pending Release
44

5+
### 3.2.2
6+
* Add header `TE: trailers` for envoy requests.
7+
58
### 3.2.1
69

710
* `CURLOPT_CONTENT_TYPE` is deprecated; remove references and allow `CURLOPT_HTTPHEADER` to handle Content-Type headers

src/Grphp/Client/Strategy/Envoy/RequestFactory.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ private function buildHeaders(ClientRequest $clientRequest): HeaderCollection
7272
$headers = HeaderCollection::fromRequest($clientRequest);
7373
$headers->add('Content-Type', $this->config->getContentType());
7474
$headers->add('User-Agent', $this->config->getUserAgent());
75+
// @see https://github.com/grpc/grpc/blob/653ba62/doc/PROTOCOL-HTTP2.md?plain=1#L30
76+
$headers->add('TE', 'trailers');
7577
return $headers;
7678
}
7779
}

tests/Unit/Grphp/Client/Strategy/Envoy/RequestFactoryTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ public function testBuild()
6161
$headers = $httpRequest->getHeaders();
6262
$this->assertEquals('application/grpc', $headers->get('Content-Type')->getValuesAsString());
6363
$this->assertEquals('grphp/1.0.0', $headers->get('User-Agent')->getValuesAsString());
64+
$this->assertSame('trailers', $headers->get('TE')->getValuesAsString());
6465

6566
$deadlineish = intval(microtime(true) + RequestContext::DEFAULT_TIMEOUT);
6667
$this->assertEquals($deadlineish, intval($headers->get('Deadline')->getValuesAsString()));

0 commit comments

Comments
 (0)