Merge pull request #28 from bigcommerce/php84

chore(platform): PHPMNT-177 Add PHP 8.4 to CircleCI matrix

Author: TomA-R

.circleci/config.yml

@@ -10,7 +10,7 @@ default_matrix: &default_matrix
     php-version: <<matrix.php-version>>
   matrix:
     parameters:
-      php-version: [ "8.1", "8.2", "8.3" ]
+      php-version: [ "8.1", "8.2", "8.3", "8.4" ]
 
 workflows:
   version: 2

phpunit.xml

@@ -3,7 +3,16 @@
          xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd"
          backupGlobals="false"
          colors="true"
-         bootstrap="vendor/autoload.php">
+         bootstrap="vendor/autoload.php"
+         displayDetailsOnTestsThatTriggerNotices="true"
+         displayDetailsOnTestsThatTriggerWarnings="true"
+         displayDetailsOnTestsThatTriggerErrors="true"
+         failOnNotice="true"
+         failOnWarning="true"
+         failOnDeprecation="true"
+         failOnPhpunitDeprecation="true"
+         failOnRisky="true"
+>
   <testsuites>
     <testsuite name="Injector Test Suite">
       <directory>./tests</directory>

src/Exception/InjectorInvocationException.php

@@ -15,7 +15,7 @@ class InjectorInvocationException extends ServiceException
      * @param string $message
      * @param Exception $previous
      */
-    public function __construct($message, Exception $previous = null)
+    public function __construct($message, ?Exception $previous = null)
     {
         parent::__construct($message, 0, $previous);
     }

src/Exception/MissingRequiredParameterException.php

@@ -27,7 +27,7 @@ class MissingRequiredParameterException extends ServiceException
      * @param \Exception $previous
      * @internal param int $code
      */
-    public function __construct($parameterName, $parameterType, $message, \Exception $previous = null)
+    public function __construct($parameterName, $parameterType, $message, ?\Exception $previous = null)
     {
         parent::__construct($message, 0, $previous);
         $this->parameterName = $parameterName;

src/InjectorFactory.php

@@ -18,7 +18,7 @@ class InjectorFactory
     public static function create(
         ContainerInterface $container,
         int $reflectionClassCacheSize = 50,
-        ServiceCacheInterface $serviceCache = null,
+        ?ServiceCacheInterface $serviceCache = null,
     ): InjectorInterface {
         $classInspector = new ClassInspector(
             new ReflectionClassCache($reflectionClassCacheSize),

src/InjectorServiceProvider.php

@@ -154,7 +154,7 @@ function (Container $app) use ($serviceKey) {
      * the IoC container as its first parameter.
      * @return void
      */
-    protected function lazyBind($className, callable $parameterFactory = null)
+    protected function lazyBind($className, ?callable $parameterFactory = null)
     {
         $this->bind(
             $className,
@@ -175,7 +175,7 @@ protected function lazyBind($className, callable $parameterFactory = null)
      * the IoC container as its first parameter.
      * @return void
      */
-    protected function lazyBindFactory($className, callable $parameterFactory = null)
+    protected function lazyBindFactory($className, ?callable $parameterFactory = null)
     {
         $this->bindFactory(
             $className,
@@ -193,7 +193,7 @@ protected function lazyBindFactory($className, callable $parameterFactory = null
      * @return void
      * @throws \Exception
      */
-    protected function autoBind($className, callable $parameterFactory = null)
+    protected function autoBind($className, ?callable $parameterFactory = null)
     {
         $this->bind(
             $className,
@@ -211,7 +211,7 @@ protected function autoBind($className, callable $parameterFactory = null)
      * @return void
      * @throws \Exception
      */
-    protected function autoBindFactory($className, callable $parameterFactory = null)
+    protected function autoBindFactory($className, ?callable $parameterFactory = null)
     {
         $this->bindFactory(
             $className,

src/Reflection/ParameterInspector.php

@@ -49,7 +49,7 @@ public function getSignatureByClassName($className, $methodName)
      * of this methods parameters as an array.
      * @throws \ReflectionException
      */
-    private function getMethodSignature($className, $methodName, \ReflectionClass $refClass = null)
+    private function getMethodSignature($className, $methodName, ?\ReflectionClass $refClass = null)
     {
         if (!$refClass) {
             $refClass = new \ReflectionClass($className);

src/ServiceProvider/BindingClosureFactory.php

@@ -41,7 +41,7 @@ public function __construct(LazyLoadingValueHolderFactory $proxyFactory, Injecto
      * the IoC container as its first parameter.
      * @return \Closure
      */
-    public function createAutoWireClosure($className, callable $parameterFactory = null)
+    public function createAutoWireClosure($className, ?callable $parameterFactory = null)
     {
         return function (Container $app) use ($className, $parameterFactory) {
             $parameters = $parameterFactory ? $parameterFactory($app) : [];
@@ -62,7 +62,7 @@ public function createAutoWireClosure($className, callable $parameterFactory = n
      * the IoC container as its first parameter.
      * @return callable
      */
-    public function createAutoWireProxyClosure($className, callable $parameterFactory = null)
+    public function createAutoWireProxyClosure($className, ?callable $parameterFactory = null)
     {
         return function (Container $app) use ($className, $parameterFactory) {
             $serviceFactory = $this->createAutoWireClosure($className, $parameterFactory);