Merge pull request #35 from bigcommerce/fix/psr11-string-type-hints

TomA-R · web-flow · commit 153799cbe610 · 2026-05-15T11:43:13.000+10:00
fix: add string type hints to has()/get() for psr/container 2.x compat on PHP 8.3
diff --git a/src/ProphecyMockingContainer.php b/src/ProphecyMockingContainer.php
@@ -43,7 +43,7 @@ public function checkPredictions()
      * @param string $id
      * @return mixed
      */
-    public function get($id)
+    public function get(string $id)
     {
         return $this->createOrGetMock($id)->reveal();
     }
@@ -53,7 +53,7 @@ public function get($id)
      * @param string $id
      * @return bool
      */
-    public function has($id): bool
+    public function has(string $id): bool
     {
         return (class_exists($id) || interface_exists($id));
     }

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public function checkPredictions()`
`43`	`43`	`* @param string $id`
`44`	`44`	`* @return mixed`
`45`	`45`	`*/`
`46`		`- public function get($id)`
	`46`	`+ public function get(string $id)`
`47`	`47`	`{`
`48`	`48`	`return $this->createOrGetMock($id)->reveal();`
`49`	`49`	`}`
`@@ -53,7 +53,7 @@ public function get($id)`
`53`	`53`	`* @param string $id`
`54`	`54`	`* @return bool`
`55`	`55`	`*/`
`56`		`- public function has($id): bool`
	`56`	`+ public function has(string $id): bool`
`57`	`57`	`{`
`58`	`58`	`return (class_exists($id) \|\| interface_exists($id));`
`59`	`59`	`}`