Merge pull request #116 from mcampa/STENCIL-3394-bug

STENCIL-3394 should not append configId if the file is not in assets/…

Author: mcampa

helpers/stylesheet.js

@@ -6,7 +6,11 @@ function helper(paper) {
     paper.handlebars.registerHelper('stylesheet', function (assetPath) {
         const options = arguments[arguments.length - 1];
         const configId = paper.settings['theme_config_id'];
-        const path = configId ? assetPath.replace(/\.css$/, `-${configId}.css`) : assetPath;
+        // append the configId only if the asset path starts with assets/css/
+        const path = configId && assetPath.match(/^\/?assets\/css\//)
+            ? assetPath.replace(/\.css$/, `-${configId}.css`)
+            : assetPath;
+
         const url = paper.cdnify(path);
 
         let attrs = { rel: 'stylesheet' };

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bigcommerce/stencil-paper",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "description": "A stencil plugin to register partials and helpers from handlebars and returns the compiled version for the stencil platform.",
   "main": "index.js",
   "author": "Bigcommerce",

test/helpers/stylesheet.js

@@ -43,4 +43,11 @@ describe('stylesheet helper', () => {
 
         done();
     });
+
+    it('should not append configId if the file is not in assets/css/ directory', done => {
+        expect(c('{{{stylesheet "assets/lib/style.css" }}}', { theme_config_id: 'foo' }))
+            .to.be.equal('<link data-stencil-stylesheet href="/assets/lib/style.css" rel="stylesheet">');
+
+        done();
+    });
 });