Merge pull request #73 from mcampa/bugFix

Quick fix for error: MessageFormat: 'NUM' isn't a number

Author: mcampa

helpers/helperMissing.js

@@ -0,0 +1,11 @@
+var helper = function (handlebars) {
+    this.handlebars = handlebars;
+};
+
+helper.prototype.register = function (context) {
+    this.handlebars.registerHelper('helperMissing', function () {
+    	return undefined;
+    });
+};
+
+module.exports = helper;

lib/localizer.js

@@ -124,7 +124,12 @@ internals.getTranslator = function (localeName, translations) {
             translations[key] = formatter.compile(translations[key]);
         }
 
-        return translations[key](parameters);
+        try {
+            return translations[key](parameters);
+        } catch (err) {
+            // @TODO: add proper logging
+            return '';
+        }
     };
 };
 

test/helpers/helperMissing.js

@@ -0,0 +1,22 @@
+var Code = require('code'),
+    Lab = require('lab'),
+    Paper = require('../../index'),
+    lab = exports.lab = Lab.script(),
+    describe = lab.experiment,
+    expect = Code.expect,
+    it = lab.it;
+
+function c(template, context) {
+    return new Paper().loadTemplatesSync({template: template}).render('template', context);
+}
+
+describe('helperMissing', function() {
+
+    it('should return empty string if the helper is missing', function(done) {
+
+        expect(c('{{thisHelperDoesNotExist}}', {}))
+            .to.be.equal('');
+
+        done();
+    });
+});

test/index.js

@@ -1,6 +1,6 @@
 var Code = require('code'),
     Lab = require('lab'),
-    Handlebars = require('Handlebars'),
+    Handlebars = require('handlebars'),
     Paper = require('../index'),
     lab = exports.lab = Lab.script(),
     describe = lab.experiment,