Merge pull request #764 from jmwiese/api-host-default-2

feat: strf-9345: Fallback to API_HOST constant in the absense of a provided one

Author: jmwiese

lib/StencilConfigManager.js

@@ -3,7 +3,7 @@ const fsModule = require('fs');
 const path = require('path');
 
 const fsUtilsModule = require('./utils/fsUtils');
-const { THEME_PATH } = require('../constants');
+const { THEME_PATH, API_HOST } = require('../constants');
 
 class StencilConfigManager {
     constructor({
@@ -99,14 +99,24 @@ class StencilConfigManager {
      * @param {boolean} ignoreMissingFields
      * @returns {object}
      */
-    _validateStencilConfig(config, ignoreMissingFields) {
+    _validateStencilConfig(configFile, ignoreMissingFields) {
+        const config = configFile;
+
         if (!ignoreMissingFields && (!config.normalStoreUrl || !config.customLayouts)) {
             throw new Error(
                 'Error: Your stencil config is outdated. Please run'.red +
                     ' $ stencil init'.cyan +
                     ' again.'.red,
             );
         }
+
+        if (!config.apiHost) {
+            this._logger.log(
+                `No api host found in config file, falling back to ${API_HOST}. You may need to run 'stencil init' again.`,
+            );
+            config.apiHost = API_HOST;
+        }
+
         return config;
     }
 

lib/StencilConfigManager.spec.js

@@ -16,6 +16,7 @@ const getGeneralConfig = () => ({
         },
         product: {},
     },
+    apiHost: 'https://api.bigcommerce.com',
     normalStoreUrl: 'https://url-from-stencilConfig.mybigcommerce.com',
     port: 3001,
 });
@@ -252,7 +253,7 @@ describe('StencilConfigManager unit tests', () => {
                     expect(fsUtilsStub.parseJsonFile).toHaveBeenCalledTimes(1);
                     expect(fsUtilsStub.parseJsonFile).toHaveBeenCalledWith(defaultOldConfigPath);
 
-                    expect(loggerStub.log).toHaveBeenCalledTimes(2);
+                    expect(loggerStub.log).toHaveBeenCalledTimes(3);
                     expect(loggerStub.log).toHaveBeenCalledWith(
                         expect.stringMatching(`will be replaced`),
                     );

lib/stencil-init.spec.js

@@ -98,7 +98,7 @@ describe('StencilInit integration tests', () => {
 
             expect(inquirerPromptStub).toHaveBeenCalledTimes(1);
             expect(consoleErrorStub).toHaveBeenCalledTimes(0);
-            expect(consoleLogStub).toHaveBeenCalledTimes(2);
+            expect(consoleLogStub).toHaveBeenCalledTimes(3);
             expect(saveStencilConfigStub).toHaveBeenCalledTimes(1);
 
             expect(saveStencilConfigStub).toHaveBeenCalledWith(expectedResult);
@@ -134,7 +134,7 @@ describe('StencilInit integration tests', () => {
 
             expect(inquirerPromptStub).toHaveBeenCalledTimes(0);
             expect(consoleErrorStub).toHaveBeenCalledTimes(0);
-            expect(consoleLogStub).toHaveBeenCalledTimes(2);
+            expect(consoleLogStub).toHaveBeenCalledTimes(3);
             expect(saveStencilConfigStub).toHaveBeenCalledTimes(1);
 
             expect(saveStencilConfigStub).toHaveBeenCalledWith(expectedResult);