Merge pull request #647 from MaxGenash/STRF-8672_update_eslint

STRF-8672: Update ESLint

Author: junedkazi

.eslintrc

@@ -5,26 +5,49 @@
       "impliedStrict": true
     }
   },
-  "plugins": ["jest"],
+  "plugins": ["jest", "node", "prettier"],
   "extends": [
+    "eslint:recommended",
+    "airbnb-base",
+    "plugin:node/recommended",
     "plugin:jest/recommended",
-    "plugin:jest/style"
+    "plugin:jest/style",
+    "prettier",
+    "plugin:prettier/recommended"
   ],
   "env": {
     "es2020": true,
     "jest/globals": true,
     "node": true
   },
   "rules": {
-    "curly": 2,
-    "no-eq-null": 2,
-    "comma-dangle": [ 2, "always-multiline" ],
-    "no-caller": 2,
-    "dot-notation": 0,
-    "no-debugger": 2,
-    "no-undef": 2,
-    "no-unused-vars": 2,
-    "semi": 2,
-    "arrow-parens": [2, "as-needed"]
+    /////////////////////////////////////////  Our rules  /////////////////////////////////////////
+    "no-eq-null": "error",
+
+    /////////////////////////////////////////  Overrides   ////////////////////////////////////////
+    "prettier/prettier": "warn",
+    "no-console": "off",
+    "class-methods-use-this": "off",
+    "no-continue": "off",
+    // Overwrites airbnb-base because our Node version doesn't allow to use private properies syntax yet, so we use underscores
+    "no-underscore-dangle": ["error", { "allowAfterThis": true }],
+    // Overwrites airbnb-base to allow for..of:
+    "no-restricted-syntax": [
+      "error",
+      {
+        "selector": "ForInStatement",
+        "message": "for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array."
+      },
+      {
+        "selector": "LabeledStatement",
+        "message": "Labels are a form of GOTO; using them makes code confusing and hard to maintain and understand."
+      },
+      {
+        "selector": "WithStatement",
+        "message": "`with` is disallowed in strict mode because it makes code impossible to predict and optimize."
+      }
+    ],
+    // Overwrites airbnb-base because woks badly with prettier making multyline strings ugly
+    "prefer-template": "off"
   }
 }

.github/ISSUE_TEMPLATE.md

@@ -1,8 +1,5 @@
 ### Expected behavior
 
-
 ### Actual behavior
 
-
 ### Steps to reproduce behavior
-

.github/PULL_REQUEST_TEMPLATE.md

@@ -6,8 +6,8 @@ A description about what this pull request implements and its purpose. Try to be
 
 Add links to any relevant tickets and documentation.
 
-- [Link 1](http://example.com)
-- ...
+-   [Link 1](http://example.com)
+-   ...
 
 #### Screenshots (if appropriate)
 

.github/workflows/pull_request_review.yml

@@ -4,42 +4,42 @@
 name: Tests
 
 on:
-  pull_request:
-    branches: [ master, main ]
-  push:
-    branches: [ master, main ]
+    pull_request:
+        branches: [master, main]
+    push:
+        branches: [master, main]
 
 jobs:
-  build:
-    strategy:
-      matrix:
-        node: [10.x, 12.x]
-        os: ['ubuntu-latest', 'windows-latest', 'macos-latest']
-
-    runs-on: ${{ matrix.os }}
-
-    steps:
-    - name: Checkout code
-      uses: actions/checkout@v2
-
-    - name: Use Node.js ${{ matrix.node }}
-      uses: actions/setup-node@v2-beta
-      with:
-        node-version: ${{ matrix.node }}
-
-    - name: Get npm cache directory
-      id: npm-cache
-      run: |
-        echo "::set-output name=dir::$(npm config get cache)"
-    - uses: actions/cache@v2
-      with:
-        path: ${{ steps.npm-cache.outputs.dir }}
-        key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
-        restore-keys: |
-          ${{ runner.os }}-node-
-
-    - name: Install Dependencies
-      run: npm i
-
-    - name: Run tests
-      run: npm test
+    build:
+        strategy:
+            matrix:
+                node: [10.x, 12.x]
+                os: ['ubuntu-latest', 'windows-latest', 'macos-latest']
+
+        runs-on: ${{ matrix.os }}
+
+        steps:
+            - name: Checkout code
+              uses: actions/checkout@v2
+
+            - name: Use Node.js ${{ matrix.node }}
+              uses: actions/setup-node@v2-beta
+              with:
+                  node-version: ${{ matrix.node }}
+
+            - name: Get npm cache directory
+              id: npm-cache
+              run: |
+                  echo "::set-output name=dir::$(npm config get cache)"
+            - uses: actions/cache@v2
+              with:
+                  path: ${{ steps.npm-cache.outputs.dir }}
+                  key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+                  restore-keys: |
+                      ${{ runner.os }}-node-
+
+            - name: Install Dependencies
+              run: npm i
+
+            - name: Run tests
+              run: npm test

.prettierignore

@@ -0,0 +1,6 @@
+.idea/
+.vscode
+node_modules
+.coverage/
+test/_mocks/
+

.prettierrc.json

@@ -0,0 +1,5 @@
+{
+  "printWidth": 100,
+  "trailingComma": "all",
+  "singleQuote": true
+}