Skip to content

Commit 8fb65ae

Browse files
committed
fix: simplify Windows CI setup while keeping node-sass support
- Remove complex build tools installation that was causing issues - Keep Python setup for node-sass compilation - Configure npm with proper MSVS version and Python path - Use bash shell for proper error propagation - Maintain backward compatibility with existing clients
1 parent c6b8e5c commit 8fb65ae

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

.github/workflows/pull-request-review.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,12 @@ jobs:
3131
with:
3232
python-version: '3.10'
3333

34-
- name: Install Visual Studio Build Tools
35-
if: startsWith(matrix.os, 'windows')
36-
uses: microsoft/setup-msbuild@v1.1
37-
38-
- name: Install Windows Build Tools
34+
- name: Configure npm for Windows
3935
if: startsWith(matrix.os, 'windows')
4036
run: |
41-
npm install -g node-gyp
4237
npm config set msvs_version 2019
4338
npm config set python python
39+
npm config set cache-min 86400
4440
shell: bash
4541

4642
- name: Install Dependencies

0 commit comments

Comments
 (0)