Merge pull request #42 from huntario/PSE-704

fix: PSE-704 / GH Issue #28 Customer attribute name undefined

Author: huntario

backend/services/bigcommerce/customers/index.ts

@@ -1,4 +1,5 @@
 import BigBaseApi from "../big-base-api";
+import {SUBSCRIPTION_CUSTOMER_ATTRIBUTE_NAME, SUBSCRIPTION_IDS_ATTRIBUTE_NAME } from "@/shared/constants/bigcommerce";
 
 /**
  * Customer API
@@ -97,16 +98,16 @@ export default class CustomersApi extends BigBaseApi {
    */
   public async getExistingCustomerAttributeNameIds() {
     const attributeNameSearchResults = await this.client.get(
-      `${this.baseUri}/attributes?name=${process.env.SUBSCRIPTION_CUSTOMER_ATTRIBUTE_NAME}`
+      `${this.baseUri}/attributes?name=${SUBSCRIPTION_CUSTOMER_ATTRIBUTE_NAME}`
     );
     const attributeNameSearchResults2 = await this.client.get(
-      `${this.baseUri}/attributes?name=${process.env.SUBSCRIPTION_IDS_ATTRIBUTE_NAME}`
+      `${this.baseUri}/attributes?name=${SUBSCRIPTION_IDS_ATTRIBUTE_NAME}`
     );
 
     return {
-      [process.env.SUBSCRIPTION_CUSTOMER_ATTRIBUTE_NAME]:
+      [SUBSCRIPTION_CUSTOMER_ATTRIBUTE_NAME]:
         attributeNameSearchResults.data[0]?.id,
-      [process.env.SUBSCRIPTION_IDS_ATTRIBUTE_NAME]:
+      [SUBSCRIPTION_IDS_ATTRIBUTE_NAME]:
         attributeNameSearchResults2.data[0]?.id
     };
   }

src/pages/api/store/display-settings/put.ts

@@ -7,8 +7,7 @@ import { DisplaySettingPayload } from "@/shared/payloads/DisplaySettingPayload";
 import HttpStatus from "http-status-codes";
 import { appContainer } from "@/shared/di-container/app";
 import { injectable } from "tsyringe";
-import { STOREFRONT_CONTENT_MODE } from "@/constants/bigcommerce";
-
+import { STOREFRONT_CONTENT_MODE, SUBSCRIPTION_CUSTOMER_ATTRIBUTE_NAME, SUBSCRIPTION_IDS_ATTRIBUTE_NAME } from "@/constants/bigcommerce";
 @injectable()
 export class DisplaySettingController extends BaseBigCommerceController {
   public requiresAuth = true;
@@ -121,9 +120,9 @@ export class DisplaySettingController extends BaseBigCommerceController {
       await this.bigApi.customers.upsertInitialCustomerAttributes();
     const customerAttributesUpdate = {
       customerAttributeFieldId:
-        customerAttributeIds[process.env.SUBSCRIPTION_CUSTOMER_ATTRIBUTE_NAME],
+        customerAttributeIds[SUBSCRIPTION_CUSTOMER_ATTRIBUTE_NAME],
       subscriptionsAttributeFieldId:
-        customerAttributeIds[process.env.SUBSCRIPTION_IDS_ATTRIBUTE_NAME]
+        customerAttributeIds[SUBSCRIPTION_IDS_ATTRIBUTE_NAME]
     };
 
     // Update store record with secure store URL and the script or widget ids from the upsert process above