fix revealed bug

Author: 1cg

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## [1.8.2] - 2022-10-12
+
+* Fix regression in `revealed` logic
+
 ## [1.8.1] - 2022-10-11
 
 * We now keep a count of outstanding requests for an indicator, so more than one overlapping request can share the same

README.md

@@ -34,7 +34,7 @@ By removing these arbitrary constraints htmx completes HTML as a
 ## quick start
 
 ```html
-  <script src="https://unpkg.com/htmx.org@1.8.1"></script>
+  <script src="https://unpkg.com/htmx.org@1.8.2"></script>
   <!-- have a button POST a click via AJAX -->
   <button hx-post="/clicked" hx-swap="outerHTML">
     Click Me

dist/htmx.js

@@ -71,7 +71,7 @@ return (function () {
             createWebSocket: function(url){
                 return new WebSocket(url, []);
             },
-            version: "1.8.1"
+            version: "1.8.2"
         };
 
         /** @type {import("./htmx").HtmxInternalApi} */
@@ -1414,7 +1414,7 @@ return (function () {
             if (!hasAttribute(elt,'data-hx-revealed') && isScrolledIntoView(elt)) {
                 elt.setAttribute('data-hx-revealed', 'true');
                 var nodeData = getInternalData(elt);
-                if (nodeData.initHash === attributeHash(elt)) {
+                if (nodeData.initHash) {
                     triggerEvent(elt, 'revealed');
                 } else {
                     // if the node isn't initialized, wait for it before triggering the request

dist/htmx.min.js

@@ -5,7 +5,7 @@
     "AJAX",
     "HTML"
   ],
-  "version": "1.8.1",
+  "version": "1.8.2",
   "homepage": "https://htmx.org/",
   "bugs": {
     "url": "https://github.com/bigskysoftware/htmx/issues"

dist/htmx.min.js.gz

@@ -71,7 +71,7 @@ return (function () {
             createWebSocket: function(url){
                 return new WebSocket(url, []);
             },
-            version: "1.8.1"
+            version: "1.8.2"
         };
 
         /** @type {import("./htmx").HtmxInternalApi} */
@@ -1414,7 +1414,7 @@ return (function () {
             if (!hasAttribute(elt,'data-hx-revealed') && isScrolledIntoView(elt)) {
                 elt.setAttribute('data-hx-revealed', 'true');
                 var nodeData = getInternalData(elt);
-                if (nodeData.initHash === attributeHash(elt)) {
+                if (nodeData.initHash) {
                     triggerEvent(elt, 'revealed');
                 } else {
                     // if the node isn't initialized, wait for it before triggering the request

package.json

@@ -747,6 +747,14 @@ describe("hx-trigger attribute", function(){
         div2.innerHTML.should.equal("test 2");
     });
 
+    it('reveal event works when triggered by window', function()
+    {
+        this.server.respondWith("GET", "/test1", "test 1");
+        var div = make('<div hx-get="/test1" hx-trigger="revealed" style="position: absolute; top: 1px; left: 1px; border: 3px solid red">foo</div>');
+        div.innerHTML.should.equal("foo");
+        this.server.respondAll();
+        div.innerHTML.should.equal("test 1");
+    });
 
 
 })

src/htmx.js

@@ -113,7 +113,7 @@ The fastest way to get going with htmx is to load it via a CDN. You can simply a
 and get going:
 
 ```html
-<script src="https://unpkg.com/htmx.org@1.8.1" integrity="sha384-DXaTz/CiqGNRLEu025rPC9D2gEK8Imn+w1e1QtdYD0Bap7LIcHOYjUZAO96YDCX3" crossorigin="anonymous"></script>
+<script src="https://unpkg.com/htmx.org@1.8.2" integrity="sha384-DXaTz/CiqGNRLEu025rPC9D2gEK8Imn+w1e1QtdYD0Bap7LIcHOYjUZAO96YDCX3" crossorigin="anonymous"></script>
 ```
 
 While the CDN approach is extremely simple, you may want to consider [not using CDNs in production](https://blog.wesleyac.com/posts/why-not-javascript-cdn).

test/attributes/hx-trigger.js

@@ -33,7 +33,7 @@ By removing these arbitrary constraints, htmx completes HTML as a [hypertext](ht
 ## quick start
 
 ```html
-  <script src="https://unpkg.com/htmx.org@1.8.1"></script>
+  <script src="https://unpkg.com/htmx.org@1.8.2"></script>
   <!-- have a button POST a click via AJAX -->
   <button hx-post="/clicked" hx-swap="outerHTML">
     Click Me