Merge pull request #31 from bijaykumarpun/fix/cleanups

Fix/cleanups: Minor cleanups

Author: bijaykumarpun

.gitignore

@@ -7,6 +7,7 @@ local.properties
 
 # Log/OS Files
 *.log
+app/.DS_Store
 
 # Android Studio generated files and folders
 captures/
@@ -31,3 +32,6 @@ google-services.json
 
 # Android Profiling
 *.hprof
+
+# Release
+app/release/*

app/src/main/java/global/x/weather/infrastructure/util/LiveDataExtension.kt

@@ -8,17 +8,6 @@ fun LiveData<Boolean>.observeAsAction(
     action: () -> Unit,
     onActionResolved: () -> Unit
 ) {
-    // LiveData will only keep one subscription per-LifecycleOwner. If one is already present the
-    // new LiveData.observe() call will have no effect. See implementation of LiveData.observe() for
-    // reference. If action relies on variable parameters subsequent calls would be ignored and the
-    // old set of parameters will be used.
-    //
-    // The most common example is action using a CoroutineScope provided by a Composable. The
-    // CoroutineScope can change if the Composable is recreated (not just recomposed). By default
-    // the old scope would be used instead of the new one.
-    //
-    // To resolve this problem we remove previous observers on the provided LifecycleOwner is
-    // BEFORE calling LiveData.observe() to ensure a new subscription with new parameters.
     this.removeObservers(lifecycleOwner)
     this.observe(lifecycleOwner) { isActionRequested ->
         if (isActionRequested == true) {
@@ -33,17 +22,6 @@ fun <T> LiveData<T?>.observeAsAction(
     action: (T) -> Unit,
     onActionResolved: () -> Unit
 ) {
-    // LiveData will only keep one subscription per-LifecycleOwner. If one is already present the
-    // new LiveData.observe() call will have no effect. See implementation of LiveData.observe() for
-    // reference. If action relies on variable parameters subsequent calls would be ignored and the
-    // old set of parameters will be used.
-    //
-    // The most common example is action using a CoroutineScope provided by a Composable. The
-    // CoroutineScope can change if the Composable is recreated (not just recomposed). By default
-    // the old scope would be used instead of the new one.
-    //
-    // To resolve this problem we remove previous observers on the provided LifecycleOwner is
-    // BEFORE calling LiveData.observe() to ensure a new subscription with new parameters.
     this.removeObservers(lifecycleOwner)
     this.observe(lifecycleOwner) { actionParams ->
         if (actionParams != null) {