From 8cc903cca574c158abd1f8bf59c325a95c7ceecf Mon Sep 17 00:00:00 2001 From: David Pashley Date: Thu, 8 May 2025 08:29:34 +0000 Subject: [PATCH] Update LaravelHttpClientLoggerServiceProvider.php Explicitly mark parameter $logger as nullable The parameter has a default value of null, but isn't explicitly marked as nullable, which causes a warning in PHP 8.4 --- src/LaravelHttpClientLoggerServiceProvider.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/LaravelHttpClientLoggerServiceProvider.php b/src/LaravelHttpClientLoggerServiceProvider.php index de62aaf..5d084e3 100644 --- a/src/LaravelHttpClientLoggerServiceProvider.php +++ b/src/LaravelHttpClientLoggerServiceProvider.php @@ -59,7 +59,7 @@ public function packageBooted() } }); - PendingRequest::macro('logWith', function (HttpLoggerInterface $logger = null): PendingRequest { + PendingRequest::macro('logWith', function (?HttpLoggerInterface $logger = null): PendingRequest { /** @var \Illuminate\Http\Client\PendingRequest $this */ return $this->withMiddleware((new LoggingMiddleware($logger, new LogAllFilter()))->__invoke()); });