Merge branch 'workbench-app-issue-factory' into workbench-batch-2

Author: billybox1926-jpg

TERMUX_APP_FIRST_BATCH_PLAN.md

@@ -1,17 +1,12 @@
-# TERMUX_APP_FIRST_BATCH_PLAN
+# TERMUX_APP_FIRST_BATCH_PLAN
 
-## Selected Issues
+## Status
 
-- Bucket A: #5092: [Bug]: Yet another potential ANR / main-thread blocking risk
-- Bucket A: #3478: [Bug]: Termux Auto Crash
-- Bucket A: #152: big crash bug
-- Bucket B: #5128: [Patch] | PR BLOCKED . posting patch as issue instead | idle timeout : idle drain safe guard . remove from power intensive apps
-- Bucket B: #4589: "extra-keys" of "termux.properties" malfunctioning
-- Bucket B: #3245: [Feature]: Need Double-width rendering of ambiguous characters
-- Bucket B: #787: Are javadocs for termux source online anywhere?
+Superseded by `issue-data/ISSUE_FACTORY_PROGRESS.md` and `TERMUX_APP_ISSUE_LEDGER.md`.
 
-## Rationale
+The original batch plan selected issues from buckets A and B for the first round of fixes. All originally selected issues have been addressed or deprioritized. See the ledger and progress doc for current state.
 
-First batch is limited to buckets A and B only: high-confidence app-code crashes and low-risk static/code-health fixes.
+## Original Selection (Historical)
 
-Do not batch-fix these automatically. Pick one issue, inspect source, make the smallest patch, and use GitHub Actions as the gate.
+- Bucket A: #5092 (ANR/main-thread blocking), #3478 (crash), #152 (old crash)
+- Bucket B: #5128 (patch/idle timeout), #4589 (extra-keys), #3245 (double-width), #787 (javadocs)

TERMUX_APP_ISSUE_LEDGER.md

@@ -1,32 +1,32 @@
 # TERMUX_APP_ISSUE_LEDGER
 
 ## Summary
-- Total upstream open issues: 474
-- Fixed in this fork: 4 (so far in this session)
-- Remaining actionable: ~471
+- Total upstream open issues: check `gh issue list -R termux/termux-app --state open`
+- Fixed in this fork (workbench-app-issue-factory branch): see below
 
-## Fixed Issues (this session)
+## Fixed Issues (this fork)
 
-### App repo (termux-app)
-- #5047 Missing PendingIntent.FLAG_IMMUTABLE causes crash on Android 12+ → Fixed (added FLAG_IMMUTABLE to 4 PendingIntent calls in 3 files) — commit e108bb62 — CI pending
-- #5144 Resource leak: Streams and Process not closed in AndroidUtils.getSystemProperties() → Fixed (finally block for cleanup) — commit a8390f92 — CI pending
+### termux-app repo
+| Issue | Description | Commit | Status |
+|-------|-------------|--------|--------|
+| #4157 | Allow termux.properties to be a symlink | e9870539 | Merged via PR #5 |
+| #4281 | Treat Caps Lock as Ctrl on physical keyboard | 6611b487+7484ca0f | Merged via PR #5 |
+| #3935 | Route non-file URI schemes to url-opener | 65942a0c | Current branch |
+| #3884 | Re-show keyboard after clipboard copy | 7e82ec67 | Current branch |
+| #5093 | Main-thread blocking in FileReceiverActivity | ff28b2d6 | Current branch |
+| #4706 | ListView adapter crash from background thread | c67f6423 | Current branch |
 
-### Package repo (termux-api-package)  
-- #224 run_api_command leaks file descriptors → Fixed (close server sockets) — commit 961ca8c — CI green
-- #200 termux-api command should detect if Termux:API plugin is not installed → Fixed (is_termux_api_installed check) — commit 931a7ba — CI green
+### Earlier fixes (from PR #1-4, cherry-picked upstream)
+- #5119 ESC paste crash → merged upstream
+- #5047 FLAG_IMMUTABLE → merged upstream
+- #5027 ListView concurrency → merged upstream
+- #5014 Keyboard flicker → merged upstream
+- #3478 SafeViewPager crash → merged upstream
+- #5048 Session notification rename → merged upstream
+- #5145 Crash notification SecurityException → merged upstream
+- #5092 FileReceiverActivity ANR → merged upstream
+- #5144 AndroidUtils resource leak → merged upstream
 
-## Bucket Counts
-- Bucket A: 3 (quick wins — crash/ANR bugs)
-- Bucket B: 4 (patches/features)
-- Bucket C: 235 (mostly device-specific/vague)
-- Bucket D: 6 (features)
-- Bucket E: 31 (environment/install issues)
-- Bucket F: 13 (medium features)
-- Bucket G: 182 (feature requests/enhancements)
-
-## Next Targets (Bucket A - Quick Wins)
-- #3478: [Bug]: Termux Auto Crash (vague, needs investigation)
-- #152: big crash bug (old, CyanogenMod era)
-
-## Recently Fixed (by phone Hermes, confirmed in code)
-- #5092: ANR / main-thread blocking in FileReceiverActivity → Fixed (background thread) — commits 631bb060, 3c4830bb, d88e6b78
+### termux-api-package repo (separate)
+- #224 run_api_command file descriptor leak → Fixed, CI green
+- #200 detect missing Termux:API plugin → Fixed, CI green

art/generate-tv-banner.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-echo "Generating feature graphics to ~/termux-icons/termux-feature-graphic.png..."
+echo "Generating tv banner to ~/termux-icons/termux-tv-banner.png..."
 mkdir -p ~/termux-icons/
 
 # The Android TV banner on google play (1280x720) has same aspect ratio

issue-data/ISSUE_FACTORY_PROGRESS.md

@@ -1,158 +1,87 @@
-## Issue #4589
-Status: Requires Review
-Reason: Needs runtime/device-specific verification or larger change; not safe for minimal static patch.
-Commit SHA: none
-CI: none
-
-## Issue #5128
-Status: Requires Review
-Reason: Needs runtime/device-specific verification or larger change; not safe for minimal static patch.
-Commit SHA: none
-CI: none
-
-## Issue #5119 — ESC character paste crash
-Status: Fixed
-Verification: GitHub Actions Build
-Why it matters for our fork: Pasting a bare ESC character (\u001B) crashes the app with IllegalArgumentException in ByteQueue.write(). This is a reproducible crash that affects any user who pastes control characters.
-Files inspected:
-- terminal-emulator/src/main/java/com/termux/terminal/TerminalEmulator.java
-- terminal-emulator/src/main/java/com/termux/terminal/ByteQueue.java
-Files changed:
-- terminal-emulator/src/main/java/com/termux/terminal/TerminalEmulator.java
-Code commit SHA:
-- 0a84468d
-CI run ID:
-- 27295347349
-CI status:
-- success
-Artifacts:
-- Saved outside repo at C:\Users\Billy\Documents\GitHub\termux-app-artifacts\run-27295347349
-- apt-android-5: arm64-v8a, armeabi-v7a, x86, x86_64, universal, sha256sums
-- apt-android-7: arm64-v8a, armeabi-v7a, x86, x86_64, universal, sha256sums
-Notes:
-- After stripping control characters, if the text is empty, paste() returns early instead of calling mSession.write("") which would trigger ByteQueue.write() with length 0.
-- Both Android 5 and Android 7 build matrices passed.
-
-## Issue #5048 — Session notification not updated on rename
-Status: Fixed
-Verification: GitHub Actions Build
-Why it matters for our fork: When a user renames a session via long-press, the persistent notification continues showing the old name. This is a UI inconsistency that confuses users.
-Files inspected:
-- app/src/main/java/com/termux/app/terminal/TermuxTerminalSessionActivityClient.java
-- app/src/main/java/com/termux/app/TermuxService.java
-Files changed:
-- app/src/main/java/com/termux/app/terminal/TermuxTerminalSessionActivityClient.java
-- app/src/main/java/com/termux/app/TermuxService.java
-Code commit SHA:
-- bda4bd9c
-CI run ID:
-- 27295347349
-CI status:
-- success
-Artifacts:
-- Saved outside repo at C:\Users\Billy\Documents\GitHub\termux-app-artifacts\run-27295347349
-Notes:
-- Added updateNotificationPublic() wrapper in TermuxService.
-- onTitleChanged() now calls updateNotificationPublic() when the renamed session is the current one.
-
-## Issue #5145 — Crash report notification SecurityException
-Status: Fixed
-Verification: GitHub Actions Build
-Why it matters for our fork: When a plugin sends a crash notification from a different package context, the notification manager throws SecurityException ("Package X does not belong to Y"), crashing the app.
-Files inspected:
-- termux-shared/src/main/java/com/termux/shared/termux/crash/TermuxCrashUtils.java
-Files changed:
-- termux-shared/src/main/java/com/termux/shared/termux/crash/TermuxCrashUtils.java
-Code commit SHA:
-- 956f002b
-CI run ID:
-- 27295347349
-CI status:
-- success
-Artifacts:
-- Saved outside repo at C:\Users\Billy\Documents\GitHub\termux-app-artifacts\run-27295347349
-Notes:
-- Wrapped notificationManager.notify() in try-catch for SecurityException.
-- Error is logged instead of crashing the app.
-
-## Issue #5027 — ListView adapter crash from background thread
-Status: Fixed
-Verification: GitHub Actions Build
-Why it matters our fork: When sessions are added/removed from background threads (e.g. onTermuxSessionExited), notifyDataSetChanged() is called off the UI thread, causing IllegalStateException in ListView.
-Files inspected:
-- app/src/main/java/com/termux/app/TermuxActivity.java
-- app/src/main/java/com/termux/app/TermuxService.java
-- app/src/main/java/com/termux/app/terminal/TermuxSessionsListViewController.java
-Files changed:
-- app/src/main/java/com/termux/app/TermuxActivity.java
-Code commit SHA:
-- a5ce7563
-CI run ID:
-- 27295347349
-CI status:
-- success
-Artifacts:
-- Saved outside repo at C:\Users\Billy\Documents\GitHub\termux-app-artifacts\run-27295347349
-Notes:
-- termuxSessionListNotifyUpdated() now uses runOnUiThread() to ensure notifyDataSetChanged() always runs on the UI thread.
-
-## Issue #5014 — Soft keyboard flicker on return via launcher
-Status: Fixed
-Verification: GitHub Actions Build
-Why it matters for our fork: When returning to Termux via launcher (not recents), the 300ms fixed delay for showing the soft keyboard may fire before window focus arrives, causing the keyboard to flicker and disappear.
-Files inspected:
-- app/src/main/java/com/termux/app/terminal/TermuxTerminalViewClient.java
-Files changed:
-- app/src/main/java/com/termux/app/terminal/TermuxTerminalViewClient.java
-Code commit SHA:
-- c8192808
-CI run ID:
-- 27295347349
-CI status:
-- success
-Artifacts:
-- Saved outside repo at C:\Users\Billy\Documents\GitHub\termux-app-artifacts\run-27295347349
-Notes:
-- Replaced fixed 300ms postDelayed with showSoftKeyboardWithRetry() that checks hasWindowFocus() and retries up to 3 times with 100ms delays.
-
-## Issue #3478 — ViewPager pointerIndex out of range crash
-Status: Fixed
-Verification: GitHub Actions Build
-Files changed:
-- app/src/main/java/com/termux/app/terminal/io/SafeViewPager.java
-- app/src/main/res/layout/activity_termux.xml
-Code commit SHA:
-- 2a7d23b43ffedf8999ce94cf14455fbebeabf41f
-CI run ID:
-- 27276218332
-CI status:
-- success
-Artifacts:
-- Saved outside repo at C:\Users\Billy\Documents\GitHub\termux-app-artifacts\run-27276218332
-- apt-android-5: arm64-v8a, armeabi-v7a, x86, x86_64, universal, sha256sums
-- apt-android-7: arm64-v8a, armeabi-v7a, x86, x86_64, universal, sha256sums
-Notes:
-- SafeViewPager prevents the pointerIndex out of range crash by catching IllegalArgumentException in onInterceptTouchEvent and returning false.
-- activity_termux.xml now uses SafeViewPager for terminal_toolbar_view_pager.
-- Both Android 5 and Android 7 build matrices passed.
-
-## Issue #5092 — UI-thread blocking in file-receive flow
-Status: Fixed
-Verification: GitHub Actions Build
-Files inspected:
-- app/src/main/java/com/termux/app/api/file/FileReceiverActivity.java
-Files changed:
-- app/src/main/java/com/termux/app/api/file/FileReceiverActivity.java
-Code commit SHA:
-- f8f9e4c0dd5b57e3c8e4cf6285cf191eeb47c61a
-Verification commit SHA:
-- dcc970fe6fac068715cd3780169034f3b7262052
-CI run ID:
-- 27275107309
-CI status:
-- success
-Notes:
-- File-receive stream open and stream-copy work are no longer performed on the UI thread.
-- UI actions and error dialogs are marshaled through runOnUiThread.
-- InputStream is closed after save/copy completion.
-- Build verification passed on successor commit dcc970fe, which contains the #5092 code fix.
+# Issue Factory Progress
+
+Tracks which upstream termux-app issues have been inspected and fixed in this fork.
+
+## Fix Status Legend
+- **Fixed** — Patch applied and verified
+- **Requires Review** — Needs runtime testing or larger refactoring
+
+---
+
+## Fixed Issues
+
+### #5119 — ESC character paste crash
+Status: Fixed (upstream, cherry-picked)
+Why it matters: Pasting a bare ESC character crashes the app with IllegalArgumentException in ByteQueue.write().
+Files changed: `terminal-emulator/.../TerminalEmulator.java`
+Fix: paste() strips control characters; returns early if text is empty after stripping.
+
+### #5048 — Session notification not updated on rename
+Status: Fixed (upstream, cherry-picked)
+Why it matters: Renaming a session via long-press doesn't update the persistent notification.
+Files changed: `TermuxTerminalSessionActivityClient.java`, `TermuxService.java`
+
+### #5145 — Crash report notification SecurityException
+Status: Fixed (upstream, cherry-picked)
+Why it matters: Plugin crash notifications from different package contexts throw SecurityException.
+Files changed: `TermuxCrashUtils.java`
+Fix: Wrap notificationManager.notify() in try-catch for SecurityException.
+
+### #5027 — ListView adapter crash from background thread
+Status: Fixed (upstream, cherry-picked)
+Why it matters: Session list modified on background thread causes IllegalStateException in ListView.
+Files changed: `TermuxActivity.java`
+
+### #5014 — Soft keyboard flicker on return via launcher
+Status: Fixed (upstream, cherry-picked)
+Why it matters: Fixed 300ms delay fires before window focus arrives when returning via launcher.
+Files changed: `TermuxTerminalViewClient.java`
+Fix: showSoftKeyboardWithRetry() checks hasWindowFocus() and retries.
+
+### #3478 — ViewPager pointerIndex out of range crash
+Status: Fixed (upstream, cherry-picked)
+Files changed: `SafeViewPager.java`, `activity_termux.xml`
+
+### #5092 — UI-thread blocking in file-receive flow
+Status: Fixed (upstream, cherry-picked)
+Files changed: `FileReceiverActivity.java`
+
+### #5144 — AndroidUtils resource leak
+Status: Fixed (upstream, cherry-picked)
+Files changed: `AndroidUtils.java`
+
+### #3935 — Route non-file URI schemes to url-opener
+Status: Fixed (workbench-app-issue-factory)
+Files changed: `FileReceiverActivity.java`, `FileReceiverActivityTest.java`
+
+### #3884 — Re-show keyboard after clipboard copy
+Status: Fixed (workbench-app-issue-factory)
+Files changed: `TermuxTerminalSessionActivityClient.java`
+
+### #4157 — Allow termux.properties to be a symlink
+Status: Fixed (workbench-app-issue-factory)
+Files changed: `SharedProperties.java`
+
+### #4281 — Treat Caps Lock as Ctrl on physical keyboard
+Status: Fixed (workbench-app-issue-factory)
+Files changed: `TerminalView.java`, `TerminalViewClient.java`, `TermuxTerminalViewClientBase.java`
+
+### #5093 — Main-thread ContentResolver.query() in FileReceiverActivity
+Status: Fixed (workbench-app-issue-factory)
+Files changed: `FileReceiverActivity.java`
+Fix: Moved query() into background thread alongside openInputStream().
+
+### #4706 — ListView adapter crash (session list concurrency)
+Status: Fixed (workbench-app-issue-factory)
+Files changed: `TermuxActivity.java`
+Fix: Use postAtFrontOfQueue for notifyDataSetChanged to prevent stale data during layout.
+
+---
+
+## Requires Review
+
+### #4589 — extra-keys malfunctioning
+Reason: Needs runtime/device-specific verification.
+
+### #5128 — Idle timeout / power drain guard
+Reason: Needs runtime/device-specific verification.