Skip to content

Commit cf6e8b9

Browse files
committed
fix: 修正保障单接口字段契约
1 parent 5e2bb6f commit cf6e8b9

10 files changed

Lines changed: 24 additions & 53 deletions

File tree

weixin-java-channel/src/main/java/me/chanjar/weixin/channel/api/impl/WxChannelAfterSaleServiceImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,14 +163,14 @@ public WxChannelBaseResponse handleFastExchangeReceipt(AfterSaleHandleFastExchan
163163

164164
@Override
165165
public GuaranteeOrderResponse getGuaranteeOrder(String guaranteeOrderId) throws WxErrorException {
166-
GuaranteeIdParam param = new GuaranteeIdParam(guaranteeOrderId);
166+
GuaranteeOrderIdParam param = new GuaranteeOrderIdParam(guaranteeOrderId);
167167
String resJson = shopService.post(AFTER_SALE_GET_GUARANTEE_ORDER_URL, param);
168168
return ResponseUtils.decode(resJson, GuaranteeOrderResponse.class);
169169
}
170170

171171
@Override
172172
public WxChannelBaseResponse merchantAcceptGuarantee(String guaranteeOrderId) throws WxErrorException {
173-
GuaranteeIdParam param = new GuaranteeIdParam(guaranteeOrderId);
173+
GuaranteeOrderIdParam param = new GuaranteeOrderIdParam(guaranteeOrderId);
174174
String resJson = shopService.post(AFTER_SALE_MERCHANT_ACCEPT_GUARANTEE_URL, param);
175175
return ResponseUtils.decode(resJson, WxChannelBaseResponse.class);
176176
}

weixin-java-channel/src/main/java/me/chanjar/weixin/channel/bean/after/GuaranteeInfo.java

Lines changed: 0 additions & 14 deletions
This file was deleted.

weixin-java-channel/src/main/java/me/chanjar/weixin/channel/bean/after/GuaranteeMerchantModifyParam.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
@Data
99
@EqualsAndHashCode(callSuper = true)
1010
@JsonInclude(JsonInclude.Include.NON_NULL)
11-
public class GuaranteeMerchantModifyParam extends GuaranteeIdParam {
11+
public class GuaranteeMerchantModifyParam extends GuaranteeOrderIdParam {
1212
private static final long serialVersionUID = 9193536167701367687L;
1313

1414
@JsonProperty("bad_level")

weixin-java-channel/src/main/java/me/chanjar/weixin/channel/bean/after/GuaranteeMerchantProofParam.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,12 @@
88
@Data
99
@EqualsAndHashCode(callSuper = true)
1010
@JsonInclude(JsonInclude.Include.NON_NULL)
11-
public class GuaranteeMerchantProofParam extends GuaranteeIdParam {
11+
public class GuaranteeMerchantProofParam extends GuaranteeOrderIdParam {
1212
private static final long serialVersionUID = -2365495841866160967L;
1313

14-
@JsonProperty("proof_info")
15-
private GuaranteeProofInfo proofInfo;
14+
@JsonProperty("content")
15+
private String content;
16+
17+
@JsonProperty("pic_list")
18+
private java.util.List<String> picList;
1619
}

weixin-java-channel/src/main/java/me/chanjar/weixin/channel/bean/after/GuaranteeIdParam.java renamed to weixin-java-channel/src/main/java/me/chanjar/weixin/channel/bean/after/GuaranteeOrderIdParam.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
@NoArgsConstructor
1212
@AllArgsConstructor
1313
@JsonInclude(JsonInclude.Include.NON_NULL)
14-
public class GuaranteeIdParam implements Serializable {
14+
public class GuaranteeOrderIdParam implements Serializable {
1515
private static final long serialVersionUID = 4325797703077757139L;
16-
@JsonProperty("guarantee_id")
17-
private String guaranteeId;
16+
@JsonProperty("guarantee_order_id")
17+
private String guaranteeOrderId;
1818
}
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package me.chanjar.weixin.channel.bean.after;
22

33
import com.fasterxml.jackson.annotation.JsonProperty;
4+
import com.fasterxml.jackson.databind.JsonNode;
45
import lombok.Data;
56
import lombok.EqualsAndHashCode;
67
import me.chanjar.weixin.channel.bean.base.WxChannelBaseResponse;
@@ -10,6 +11,6 @@
1011
public class GuaranteeOrderResponse extends WxChannelBaseResponse {
1112
private static final long serialVersionUID = 3977781489692530604L;
1213

13-
@JsonProperty("guarantee_info")
14-
private GuaranteeInfo guaranteeInfo;
14+
@JsonProperty("guarantee_order")
15+
private JsonNode guaranteeOrder;
1516
}

weixin-java-channel/src/main/java/me/chanjar/weixin/channel/bean/after/GuaranteeProofInfo.java

Lines changed: 0 additions & 17 deletions
This file was deleted.

weixin-java-channel/src/test/java/me/chanjar/weixin/channel/api/impl/WxChannelAfterSaleServiceImplTest.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import me.chanjar.weixin.channel.bean.after.AfterSaleVirtualTelNumResponse;
2222
import me.chanjar.weixin.channel.bean.after.GuaranteeMerchantModifyParam;
2323
import me.chanjar.weixin.channel.bean.after.GuaranteeMerchantProofParam;
24-
import me.chanjar.weixin.channel.bean.after.GuaranteeProofInfo;
2524
import me.chanjar.weixin.channel.bean.after.GuaranteeOrderResponse;
2625
import me.chanjar.weixin.channel.bean.after.SyncWorkOrderParam;
2726
import me.chanjar.weixin.channel.bean.base.WxChannelBaseResponse;
@@ -222,7 +221,7 @@ public void testMerchantAcceptGuarantee() throws WxErrorException {
222221
public void testMerchantModifyGuarantee() throws WxErrorException {
223222
WxChannelAfterSaleService afterSaleService = channelService.getAfterSaleService();
224223
GuaranteeMerchantModifyParam param = new GuaranteeMerchantModifyParam();
225-
param.setGuaranteeId("");
224+
param.setGuaranteeOrderId("");
226225
param.setBadLevel(10);
227226
param.setMerchantRemark("remark");
228227
WxChannelBaseResponse response = afterSaleService.merchantModifyGuarantee(param);
@@ -234,11 +233,9 @@ public void testMerchantModifyGuarantee() throws WxErrorException {
234233
public void testMerchantProofGuarantee() throws WxErrorException {
235234
WxChannelAfterSaleService afterSaleService = channelService.getAfterSaleService();
236235
GuaranteeMerchantProofParam param = new GuaranteeMerchantProofParam();
237-
param.setGuaranteeId("");
238-
GuaranteeProofInfo proofInfo = new GuaranteeProofInfo();
239-
proofInfo.setText("proof");
240-
proofInfo.setImageIds(new ArrayList<>(4));
241-
param.setProofInfo(proofInfo);
236+
param.setGuaranteeOrderId("");
237+
param.setContent("proof");
238+
param.setPicList(new ArrayList<>(4));
242239
WxChannelBaseResponse response = afterSaleService.merchantProofGuarantee(param);
243240
assertNotNull(response);
244241
assertTrue(response.isSuccess());

weixin-java-channel/src/test/java/me/chanjar/weixin/channel/bean/after/AfterSaleContractTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,20 @@ public void shouldUseOfficialAfterSaleAndGuaranteeFieldNames() throws Exception
2020
AfterSaleHandleFastExchangeReceiptParam receiptParam = new AfterSaleHandleFastExchangeReceiptParam();
2121
receiptParam.setRejectConfirmExchange(Collections.singletonList("media-1"));
2222

23-
GuaranteeIdParam guaranteeParam = new GuaranteeIdParam("guarantee-1");
23+
GuaranteeOrderIdParam guaranteeParam = new GuaranteeOrderIdParam("guarantee-1");
2424
assertTrue(OBJECT_MAPPER.writeValueAsString(afterSaleParam).contains("\"exchange_sku_info\":{\"new_sku_id\":\"new-sku\"}"));
2525
assertTrue(OBJECT_MAPPER.writeValueAsString(receiptParam).contains("\"reject_confirm_exchange\":[\"media-1\"]"));
26-
assertTrue(OBJECT_MAPPER.writeValueAsString(guaranteeParam).contains("\"guarantee_id\":\"guarantee-1\""));
26+
assertTrue(OBJECT_MAPPER.writeValueAsString(guaranteeParam).contains("\"guarantee_order_id\":\"guarantee-1\""));
2727
}
2828

2929
@Test
3030
public void shouldDecodeOfficialResponseFields() throws Exception {
3131
AfterSaleCreateResponse createResponse = OBJECT_MAPPER.readValue(
3232
"{\"errcode\":0,\"after_sale_order_id\":\"after-1\"}", AfterSaleCreateResponse.class);
3333
GuaranteeOrderResponse guaranteeResponse = OBJECT_MAPPER.readValue(
34-
"{\"errcode\":0,\"guarantee_info\":{\"guarantee_id\":\"guarantee-1\"}}", GuaranteeOrderResponse.class);
34+
"{\"errcode\":0,\"guarantee_order\":{\"guarantee_order_id\":\"guarantee-1\"}}", GuaranteeOrderResponse.class);
3535

3636
assertEquals(createResponse.getAfterSaleOrderId(), "after-1");
37-
assertEquals(guaranteeResponse.getGuaranteeInfo().getGuaranteeId(), "guarantee-1");
37+
assertEquals(guaranteeResponse.getGuaranteeOrder().get("guarantee_order_id").asText(), "guarantee-1");
3838
}
3939
}

weixin-java-channel/src/test/resources/testng.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
<class name="me.chanjar.weixin.channel.util.XmlUtilsTest"/>
1515
<class name="me.chanjar.weixin.channel.util.WxChCryptUtilsTest"/>
1616
<class name="me.chanjar.weixin.channel.util.ResponseUtilsTest"/>
17+
<class name="me.chanjar.weixin.channel.bean.after.AfterSaleContractTest"/>
1718
</classes>
1819
</test>
1920
</suite>

0 commit comments

Comments
 (0)