Skip to content

Commit 4240e52

Browse files
wasadeclaude
andcommitted
Use Redis service container for integration tests
Replaces the apt-installed redis-server daemonized in the run script with a service container, consistent with the postgres pattern. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 37adfbd commit 4240e52

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

.github/workflows/main.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,15 @@ jobs:
7373
ports:
7474
# based on https://github.com/actions/example-services/blob/master/.github/workflows/postgres-service.yml#L44-L72
7575
- 5432/tcp
76+
redis:
77+
image: redis
78+
ports:
79+
- 6379/tcp
80+
options: >-
81+
--health-cmd "redis-cli ping"
82+
--health-interval 10s
83+
--health-timeout 5s
84+
--health-retries 5
7685
7786
steps:
7887
# Downloads a copy of the code in your repository before running CI tests
@@ -128,7 +137,6 @@ jobs:
128137
popd
129138
130139
conda activate microsetta-interface
131-
redis-server --daemonize yes
132140
source keys_for_testing.sh
133141
python microsetta_interface/tests/test_integration.py 2> >(tee -a stderr.log >&2)
134142

0 commit comments

Comments
 (0)