Skip to content

Commit dd07e0a

Browse files
authored
Merge pull request #572 from biocore/csymons_block_shipping_emails
Block Shipping Emails on Staging
2 parents cfdefca + 9f4e0e3 commit dd07e0a

File tree

1 file changed

+16
-13
lines changed

1 file changed

+16
-13
lines changed

microsetta_private_api/util/perk_fulfillment.py

+16-13
Original file line numberDiff line numberDiff line change
@@ -82,21 +82,24 @@ def process_subscription_fulfillments():
8282
def check_shipping_updates():
8383
with Transaction() as t:
8484
pfr = PerkFulfillmentRepo(t)
85-
emails_sent, error_report = pfr.check_for_shipping_updates()
85+
pf_active = pfr.check_perk_fulfillment_active()
8686

87-
if emails_sent > 0 or len(error_report) > 0:
88-
t.commit()
87+
if pf_active:
88+
emails_sent, error_report = pfr.check_for_shipping_updates()
8989

90-
email_content = f"Emails sent: {emails_sent}\n"\
91-
f"Errors: {error_report}"
92-
try:
93-
send_email(SERVER_CONFIG['pester_email'], "pester_daniel",
94-
{"what": "Automated Tracking Updates Output",
95-
"content": email_content},
96-
EN_US)
97-
except: # noqa
98-
# try our best to email
99-
pass
90+
if emails_sent > 0 or len(error_report) > 0:
91+
t.commit()
92+
93+
email_content = f"Emails sent: {emails_sent}\n"\
94+
f"Errors: {error_report}"
95+
try:
96+
send_email(SERVER_CONFIG['pester_email'], "pester_daniel",
97+
{"what": "Automated Tracking Updates Output",
98+
"content": email_content},
99+
EN_US)
100+
except: # noqa
101+
# try our best to email
102+
pass
100103

101104

102105
@celery.task(ignore_result=True)

0 commit comments

Comments
 (0)