Preprocess Text Failure

[davidfungf]

Hello!

I am a beginner of Orange. When the Preprocess Text widget is executed, it returned the following error. Any idea?

File "C:\xxx\orangecontrib\text\widgets\owpreprocess.py", line 93, in __init__items = [(ISO2LANG[itm], itm) for itm in items] TypeError: 'method' object is not iterable

Owpreprocess.py code

self.setMinimumWidth(80)
items = [(ISO2LANG[itm], itm) for itm in items]
self.add_items(items, include_none, value)
self.currentIndexChanged.connect(self.index_changed)

Remarks: Orange version 3.39

[janezd]

Thanks for the bug report. This belong to the text add-on repository, so I'm moving it there, and leaving it to @ajdapretnar to resolve.

@ajdapretnar, the problem is that StopWordsFilter.supported_languages is a @property and @classmethod. Python 3.11 no longer supports this. I think that @property is ignored, so supported_languages is a method.

The fix is probably simple, but I don't understand what's the deal with wait_nltk_data. If you don't solve it yourself, I can try to help you on Friday.

A trivial fix is to call it as a method, yet you probably care about uniformiti -- in all other classes,supported_languages is a property.

[krystofair]

@ajdapretnar @janezd seems that the simplest fix is rather remove classmethod decorator, because it does nothing. There can't pass "cls" as first argument anyway, but signature of supported_languages must be preserved for wait_nltk_data, in which (*args, **kwargs) are passed.

Seems to that change from 3.11 is not applied on my machine (AlmaLinux).
I tested this behaviour in Python 3.11 and it's worked without changes, but then install Python 3.13, and here we go!

[janezd]

But if we remove classmethod, this will be a normal method, therefore requiring self, so StopWordsFilter.supported_language would no longer work because we'd need to instantiate it first. A proper solution would be a staticmethod, but to my (possibly incorrect) knowledge, it never worked with property.

We probably need to define a property the "manual" way, without the decorator.

[krystofair]

Oh damn, I'm sorry, you are totally right - I was instantiate it in my scratches.

[krystofair]

I did some fun with it, and get this work like below.
Prepare place for self as normal class attribute and then decorate function with this new attribute.
This is probably too complicated solution, because at first create new class and need to find place for this class.

PoC

from functools import wraps
from itertools import count

def dec(f):
    """example of some decorator"""
    @wraps(f)
    def wrapper(*args,**kwargs):
        print('1000')
        return f(*args, **kwargs)
    return wrapper

class ClassProperty:
    def __init__(self, *args, **kwargs):
        self.args = args
        self.kwargs = kwargs

    def __call__(self, f):
        @wraps(f)
        def wrapper(*args, **kwargs):
            return f(*args, **kwargs)
        self.wrapped = wrapper

    def __get__(self, instance, owner):
        return self.wrapped(*self.args, **self.kwargs)

class A:
    prop = ClassProperty(10)
    prop2 = ClassProperty(count(5)) 

    @prop
    @dec
    def _(number):
        return list(map(str, range(number)))

    @prop2
    @dec
    def _(gen):
        return list(map(str, range(next(gen))))


print(A.prop)
print(', '.join(A.prop))
print(', '.join(A.prop2))
print(', '.join(A.prop2))

[janezd]

Good idea. Orange actually already has classproperty: https://github.com/biolab/orange-widget-base/blob/master/orangewidget/io.py#L77. It is derived from property, so it just calls fget - and ignores self, like yours.

We can probably just use that one.

[ajdapretnar]

@krystofair Would you care to submit the PR with the existing classproperty?

[krystofair]

@ajdapretnar ok, you can assign me to this. And I please for some time. :)