[ENH] Score Documents - Use SBERT embedding instead of FastText#930
Merged
Conversation
c26aaca to
d6e2f75
Compare
d6e2f75 to
fa942b4
Compare
Collaborator
Author
Collaborator
Author
|
/rebase |
fa942b4 to
9e01a2e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #930 +/- ##
=======================================
Coverage 77.68% 77.68%
=======================================
Files 86 86
Lines 12281 12297 +16
Branches 1607 1613 +6
=======================================
+ Hits 9540 9553 +13
- Misses 2442 2444 +2
- Partials 299 300 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Issue
SBERT embedding is (in our opinion) more suitable for measuring distances between embeddings of documents and words. The reason for it is that it embeds complete text and not words separately, which leads to a better representation of the whole context of the document.
Description of changes
This PR replaces FastText embedding with SBERT in Score Document. It also better addresses some weaknesses of the widget:
Includes