fix: do not force musl on linux (#503)

Author: nhedger

src/constants.ts

@@ -1,6 +1,24 @@
+import { spawnSync } from "node:child_process";
 import isWSL from "is-wsl";
 import { workspace } from "vscode";
 
+/**
+ * Whether the current platform uses musl
+ */
+export const isMusl = (() => {
+	// If not on Linux, or on WSL we can't be using musl
+	if (process.platform !== "linux" || isWSL) {
+		return false;
+	}
+
+	try {
+		const output = spawnSync("ldd", ["--version"], { encoding: "utf8" });
+		return output.stdout.includes("musl");
+	} catch {
+		return false;
+	}
+})();
+
 /**
  * Platform identifier
  *
@@ -14,11 +32,7 @@ import { workspace } from "vscode";
 export const platformIdentifier = (() => {
 	let flavor = "";
 
-	// On Linux, we always use the `musl` flavor because it has the advantage of
-	// having been built statically. This is meant to improve the compatibility
-	// with various systems such as NixOS, which handle dynamically linked
-	// binaries differently.
-	if (process.platform === "linux" && !isWSL) {
+	if (isMusl) {
 		flavor = "-musl";
 	}
 
@@ -44,7 +58,10 @@ export const platformSpecificBinaryName = (() => {
  * This constant contains the name of Biome CLI GitHub release asset for the
  * current platform.
  *
- * @example "biome-linux-x64"
+ * On Linux, we always return the musl flavor, as it's the most compatible
+ * since its statically linked.
+ *
+ * @example "biome-linux-x64-musl"
  * @example "biome-darwin-x64"
  * @example "biome-win32-x64.exe"
  */

src/downloader.ts

@@ -9,6 +9,7 @@ import {
 	workspace,
 } from "vscode";
 import {
+	isMusl,
 	platformSpecificAssetName,
 	platformSpecificBinaryName,
 } from "./constants";
@@ -49,8 +50,16 @@ const downloadBiomeVersion = async (
 		)
 		.json();
 
+	let assetName = platformSpecificAssetName;
+
+	// On Linux, we always want to download the musl flavor, because it's the most
+	// compatible since it's statically linked.
+	if (process.platform === "linux" && !isMusl) {
+		assetName = `${assetName}-musl`;
+	}
+
 	const asset = releases.assets.find((asset) => {
-		return asset.name === platformSpecificAssetName;
+		return asset.name === assetName;
 	});
 
 	if (!asset) {