Skip to content

🐛 biome.lsp.bin does not expand VSCode variables #721

@blixt

Description

@blixt

VS Code version

1.102.1

Extension version

3.1.0

Biome version

2.1.2

Operating system

  • Windows
  • macOS
  • Linux

Description

When configuring biome.lsp.bin in .vscode/settings.json to something like "${userHome}/.local/share/mise/installs/npm-biomejs-biome/2.1.2/bin/biome" it does not expand to a proper path (the extension fails to start properly), while if I manually expand it to "/Users/blixt/.local/share/mise/installs/npm-biomejs-biome/2.1.2/bin/biome" it does work.

Paths in VSCode settings are supposed to expand using the supported variables: https://code.visualstudio.com/docs/reference/variables-reference

This works well for me with other extensions, but for some reason not with this one. Not expanding VSCode variables will cause compatibility issues with other extensions that generate paths like mise-vscode which wants to refer to the mise-installed Biome as "${workspaceFolder}/.vscode/mise-tools/biome" for easier management (related PR: hverlin/mise-vscode#133).

Steps to reproduce

Use a variable for the biome.lsp.bin setting.

Expected behavior

The variable works just like all other path-related settings.

Does this issue occur when using the CLI directly?

Not sure / Not applicable

Link to a minimal reproduction

No response

Logs


Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions