why the rule "lint/style/useTemplate" is not safe fix?

[shmdhussain]

why converting the old string concatenation to use string template literal is not a safe fix? any reason?

I like to see why the fix is not safe in the same documentation of the rule.

// old string concatenation
const age = "20"
const hobby = "I play football"
const summary = "my age is " + age + " and " + hobby

// new string template literal
const age = "20"
const hobby = "I play football"
const summary = `my age is ${age} and ${hobby}`

[ematipico]

https://next.biomejs.dev/linter/#why-does-rule-x-have-an-unsafe-fix-it-seems-safe-to-me

[shmdhussain]

Thanks , I like to have the reason for that particular rule like why that rules fix is not a safe fix near the rules documentation.

[ematipico]

We prefer to keep a generic FAQ instead of justifying every single rule as "why a code fix is unsafe". It would be impossible to maintain. Instead, you can make the fix safe at your own leisure using the configuration: https://biomejs.dev/linter/#configure-the-rule-fix

[Conaclos]

We are regularly reviewing rules to adjust the safety of a fix. Perhaps in a future version of Biome, the default safety level of the rule's fix will be safe.

[shmdhussain]

Thanks Got it.

As mentioned in the generic document about the why the rule is unsafe, there are three reasons that can make the rule fix as unsafe.

I could do if the rule is unsafe because of DX , I can go ahead and configure it as safe fix.

Among the three reasons which are applicable for that rule, so that I can make better decision to have the rule safe fix.

If something breaks code, then I won't consider, I can consider unsafe fix as safe if it is breaking DX or rules is in testing.

[Conaclos]

I didn't extensively check the rule, however I think it is pretty safe now. We will certainly set it to safe in a near future.