fix(lint): mark whole fragment as incorrect if without key #5773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
CodSpeed Performance ReportMerging #5773 will not alter performanceComparing Summary
|
ematipico
requested changes
Apr 26, 2025
.changeset/silent-fans-battle.md
Outdated
| "@biomejs/biome": patch | ||
| --- | ||
|
|
||
| Updates the useJsxKeyInIterable rule to more closely match the behavior of the ESLint plugin (e.g. mark the whole fragment as incorrect when no key is present). This also adds the option to check shorthand fragments (`<></>`) |
There was a problem hiding this comment.
Suggested change
| Updates the useJsxKeyInIterable rule to more closely match the behavior of the ESLint plugin (e.g. mark the whole fragment as incorrect when no key is present). This also adds the option to check shorthand fragments (`<></>`) | |
| Updates the [`useJsxKeyInIterable`](https://biomejs.dev/linter/rules/use-jsx-key-in-iterable/) rule to more closely match the behavior of the ESLint plugin (e.g. mark the whole fragment as incorrect when no key is present). This also adds the option to check shorthand fragments (`<></>`) |
ematipico
reviewed
May 2, 2025
crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue with the
useJsxKeyInIterablethat did not match the original ESLint plugin: when a fragment does not have a key in a.map(or similar) call, it's children are marked as incorrect, not the whole fragment.Looking more closely at the original rule I also noticed that
checkShorthandFragmentis an opt-in check.Therefore I added the related option.
Closes #5490
Test Plan
Adapted the snapshots, removed invalid code that was found in
valid.jsx(for example: even if all children of a fragment would have keys, the fragment is still marked as incorrect in the original rule), and added an additional snapshot with the option to check shorthand fragments.