Skip to content

Commit 33b0557

Browse files
committed
Cleanup
1 parent 9a0ffda commit 33b0557

6 files changed

Lines changed: 17 additions & 8 deletions

File tree

src/bioversions/charts.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
"""Generation of charts summarizing bioversions."""
22

3+
from __future__ import annotations
4+
35
import os
46
from collections import Counter
57

src/bioversions/resources/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
"""Resources."""
22

3+
from __future__ import annotations
4+
35
import datetime
46
from pathlib import Path
57
from typing import Any

src/bioversions/resources/update.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
"""Update the web page."""
22

3+
from __future__ import annotations
4+
35
import datetime
46
import getpass
57
import sys

src/bioversions/sources/slm.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ class SwissLipidGetter(Getter):
2121
name = "SwissLipids"
2222
version_type = VersionType.date
2323

24-
def get(self) -> str:
24+
def get(self) -> datetime.date:
2525
"""Get the latest SwissLipids version number."""
2626
res = requests.get(URL, timeout=15).json()
2727
record = next(record for record in res if record["file"] == "lipids.tsv")
28-
return datetime.date.strptime(record["date"], "%B %d %Y").isoformat()
28+
return datetime.date.strptime(record["date"], "%B %d %Y")
2929

3030

3131
if __name__ == "__main__":

src/bioversions/sources/zfin.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ class ZfinGetter(Getter):
1818
name = "Zebrafish Information Network"
1919
version_type = VersionType.date
2020

21-
def get(self) -> str:
21+
def get(self) -> datetime.date:
2222
"""Get the latest ZFIN version number."""
2323
soup = get_soup(URL)
2424
header_text = find_text(soup, "h2")
2525
version = header_text[len("ZFIN Data Reports from: ") :].strip()
26-
return datetime.date.strptime(version, "%d %b %Y").isoformat()
26+
return datetime.date.strptime(version, "%d %b %Y")
2727

2828

2929
if __name__ == "__main__":

src/bioversions/utils.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
"""Utilities and implementation for bioversions."""
22

3+
from __future__ import annotations
4+
35
import datetime
46
import enum
57
import gzip
68
import io
79
import os
810
from collections.abc import Generator, Iterable, Mapping
911
from contextlib import contextmanager
10-
from typing import Any, ClassVar, NotRequired, TextIO, TypedDict, cast
12+
from typing import Any, ClassVar, TextIO, TypedDict, cast
1113

1214
import bioregistry
1315
import pydantic
@@ -17,6 +19,7 @@
1719
from bs4 import Tag
1820
from cachier import cachier
1921
from pystow.utils import get_soup
22+
from typing_extensions import NotRequired
2023

2124
__all__ = [
2225
"DailyGetter",
@@ -121,14 +124,14 @@ def find_text(element: Tag, *args: Any, **kwargs: Any) -> str:
121124
class MetaGetter(type):
122125
"""A metatype to expose two class properties."""
123126

124-
_cache: ClassVar[str | dict[str, str] | datetime.datetime | datetime.date | None] = None
127+
_cache: ClassVar[str | ReleaseDict | datetime.datetime | datetime.date | None] = None
125128

126129
date_fmt: str | None
127130
date_version_fmt: str | None
128131
homepage_fmt: str | None
129132

130133
@property
131-
def _cache_prop(cls) -> str | dict[str, str] | datetime.datetime | datetime.date:
134+
def _cache_prop(cls) -> str | ReleaseDict | datetime.datetime | datetime.date:
132135
if cls._cache is None:
133136
cls._cache = cls().get() # type:ignore
134137
return cls._cache
@@ -248,7 +251,7 @@ class Getter(metaclass=MetaGetter):
248251
#: Prefixes this getter works for
249252
collection: ClassVar[list[str] | None] = None
250253

251-
def get(self) -> str | ReleaseDict | datetime.datetime:
254+
def get(self) -> str | ReleaseDict | datetime.datetime | datetime.date:
252255
"""Get the latest of this database."""
253256
raise NotImplementedError
254257

0 commit comments

Comments
 (0)