Change contractual txid fields to strings in rpc.proto

Use strings instead of byte arrays in 'musigrpc.ContractualTxIds', as it
is awkward for the Bisq2 client to reverse the bytes and convert to hex.
Returning the raw txid bytes makes things no simpler on either end (even
though it is arguably more consistent with the way other SHA256 hashes
are represented in most of the protos).

Author: stejbac

rpc/build.rs

@@ -26,11 +26,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
         // Add Serde serialization for musigrpc request types...
         .serde_serialized_types(&[
             "ReceiverAddressAndAmount", "PartialSignaturesRequest", "DepositTxSignatureRequest",
-            "PublishDepositTxRequest", "SubscribeTxConfirmationStatusRequest"
-        ])
-        .serde_serialized_type("ContractualTxIds", &[
-            rev_hex("depositTxId"), rev_hex("buyersWarningTxId"), rev_hex("sellersWarningTxId"),
-            rev_hex("buyersRedirectTxId"), rev_hex("sellersRedirectTxId")
+            "PublishDepositTxRequest", "SubscribeTxConfirmationStatusRequest", "ContractualTxIds"
         ])
         .serde_serialized_type("PubKeySharesRequest", &[
             enum_field("myRole", "Role")

rpc/src/main/proto/rpc.proto

@@ -33,11 +33,11 @@ message ReceiverAddressAndAmount {
 }
 
 message ContractualTxIds {
-  bytes depositTxId = 1;
-  bytes buyersWarningTxId = 2;
-  bytes sellersWarningTxId = 3;
-  bytes buyersRedirectTxId = 4;
-  bytes sellersRedirectTxId = 5;
+  string depositTxId = 1;
+  string buyersWarningTxId = 2;
+  string sellersWarningTxId = 3;
+  string buyersRedirectTxId = 4;
+  string sellersRedirectTxId = 5;
 }
 
 message PubKeySharesRequest {

rpc/src/pb/convert.rs

@@ -246,14 +246,14 @@ impl From<SentAddressesNoncesPair<'_>> for NonceSharesMessage {
     }
 }
 
-impl From<ContractualTxids> for crate::pb::musigrpc::ContractualTxIds {
+impl From<ContractualTxids> for musigrpc::ContractualTxIds {
     fn from(value: ContractualTxids) -> Self {
         Self {
-            deposit_tx_id: value.deposit.to_byte_array().into(),
-            buyers_warning_tx_id: value.buyers_warning.to_byte_array().into(),
-            sellers_warning_tx_id: value.sellers_warning.to_byte_array().into(),
-            buyers_redirect_tx_id: value.buyers_redirect.to_byte_array().into(),
-            sellers_redirect_tx_id: value.sellers_redirect.to_byte_array().into(),
+            deposit_tx_id: value.deposit.to_string(),
+            buyers_warning_tx_id: value.buyers_warning.to_string(),
+            sellers_warning_tx_id: value.sellers_warning.to_string(),
+            buyers_redirect_tx_id: value.buyers_redirect.to_string(),
+            sellers_redirect_tx_id: value.sellers_redirect.to_string(),
         }
     }
 }