Merge pull request #526 from piotrsapiejewskismartbear/master

marisuch · web-flow · commit f28d680fab9c · 2025-04-08T14:19:44.000+02:00
SDCB-14412 Share Resource type fix
diff --git a/dist/api/APIResourceDeviceGroup.d.ts b/dist/api/APIResourceDeviceGroup.d.ts
@@ -13,6 +13,6 @@ export declare class APIResourceDeviceGroup extends APIResource<DeviceGroup> {
     device(id: number): APIResource<void, NoQueryParams, void>;
     selectors(): APIList<DeviceGroup | DeviceProperty, CollectionBasicQueryParams, DeviceGroupSelectorData>;
     selector(id: number): APIResource<any, import("./models/HTTP").QueryParams, import("./models/HTTP").QueryParams>;
-    share(): APIList<SharedResource, NoQueryParams, ShareData>;
+    share(): APIList<SharedResource, ShareData, ShareData>;
 }
 export default APIResourceDeviceGroup;
diff --git a/dist/api/APIResourceFile.d.ts b/dist/api/APIResourceFile.d.ts
@@ -12,7 +12,7 @@ export declare class APIResourceFile extends APIResource<UserFile> {
     file(): APIResource<UserFile, FileSizeData, void>;
     icon(): APIResource<any, import("./models/HTTP").QueryParams, import("./models/HTTP").QueryParams>;
     tags(): APIList<UserFileTag, CollectionBasicQueryParams, void>;
-    share(): APIList<SharedResource, ShareData, any>;
+    share(): APIList<SharedResource, ShareData, ShareData>;
     property(id: number): APIResource<Property, import("./models/HTTP").QueryParams, import("./models/HTTP").QueryParams>;
 }
 export default APIResourceFile;
diff --git a/dist/api/APIResourceProject.d.ts b/dist/api/APIResourceProject.d.ts
@@ -12,7 +12,7 @@ export declare class APIResourceProject extends APIResource<Project> {
     constructor(parent: API | APIAdminResource | APIResourceUser, id: number);
     runs(): APIList<TestRun, CollectionBasicQueryParams, void>;
     run(id: number): APIResourceRun;
-    share(): APIList<SharedResource, ShareData, any>;
+    share(): APIList<SharedResource, ShareData, ShareData>;
     unarchive(): APIResource<void, NoQueryParams, void>;
 }
 export default APIResourceProject;
diff --git a/dist/api/models/SharedResource.d.ts b/dist/api/models/SharedResource.d.ts
@@ -10,7 +10,10 @@ export type SharedResource = {
     resourceId: number;
     type: SharedResourceType;
 };
-export interface ShareData extends QueryParams {
+export interface ShareWithGroup extends QueryParams {
     accessGroupId: number;
+}
+export interface ShareWithEmail extends QueryParams {
     email: string;
 }
+export type ShareData = ShareWithGroup | ShareWithEmail;
diff --git a/dist/bitbar-cloud-api-client.js.map b/dist/bitbar-cloud-api-client.js.map
diff --git a/dist/bitbar-cloud-api-client.min.js.map b/dist/bitbar-cloud-api-client.min.js.map
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@bitbar/cloud-api-client",
-  "version": "1.4.5",
+  "version": "1.4.6",
   "description": "Bitbar Cloud API Client for JavaScript",
   "main": "dist/bitbar-cloud-api-client.min.js",
   "types": "dist/index.d.ts",
diff --git a/src/api/APIResourceDeviceGroup.ts b/src/api/APIResourceDeviceGroup.ts
@@ -52,7 +52,7 @@ export class APIResourceDeviceGroup extends APIResource<DeviceGroup> {
 
   // /device-groups/{id}/share
   share() {
-    return new APIList<SharedResource, NoQueryParams, ShareData>(this).push('share');
+    return new APIList<SharedResource, ShareData, ShareData>(this).push('share');
   }
 
 }
diff --git a/src/api/APIResourceFile.ts b/src/api/APIResourceFile.ts
@@ -40,7 +40,7 @@ export class APIResourceFile extends APIResource<UserFile> {
   }
 
   share() {
-    return new APIList<SharedResource, ShareData>(this).push('share');
+    return new APIList<SharedResource, ShareData, ShareData>(this).push('share');
   }
 
   property(id: number) {
diff --git a/src/api/APIResourceProject.ts b/src/api/APIResourceProject.ts
@@ -34,7 +34,7 @@ export class APIResourceProject extends APIResource<Project> {
   }
 
   share() {
-    return new APIList<SharedResource, ShareData>(this).push('share');
+    return new APIList<SharedResource, ShareData, ShareData>(this).push('share');
   }
 
   // /unarchive
diff --git a/src/api/models/SharedResource.ts b/src/api/models/SharedResource.ts
@@ -14,7 +14,12 @@ export type SharedResource = {
   type: SharedResourceType;
 }
 
-export interface ShareData extends QueryParams {
+export interface ShareWithGroup extends QueryParams {
   accessGroupId: number;
+}
+
+export interface ShareWithEmail extends QueryParams {
   email: string;
 }
+
+export type ShareData = ShareWithGroup | ShareWithEmail;

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,6 @@ export declare class APIResourceDeviceGroup extends APIResource<DeviceGroup> {`
`13`	`13`	`device(id: number): APIResource<void, NoQueryParams, void>;`
`14`	`14`	`selectors(): APIList<DeviceGroup \| DeviceProperty, CollectionBasicQueryParams, DeviceGroupSelectorData>;`
`15`	`15`	`selector(id: number): APIResource<any, import("./models/HTTP").QueryParams, import("./models/HTTP").QueryParams>;`
`16`		`- share(): APIList<SharedResource, NoQueryParams, ShareData>;`
	`16`	`+ share(): APIList<SharedResource, ShareData, ShareData>;`
`17`	`17`	`}`
`18`	`18`	`export default APIResourceDeviceGroup;`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ export declare class APIResourceFile extends APIResource<UserFile> {`
`12`	`12`	`file(): APIResource<UserFile, FileSizeData, void>;`
`13`	`13`	`icon(): APIResource<any, import("./models/HTTP").QueryParams, import("./models/HTTP").QueryParams>;`
`14`	`14`	`tags(): APIList<UserFileTag, CollectionBasicQueryParams, void>;`
`15`		`- share(): APIList<SharedResource, ShareData, any>;`
	`15`	`+ share(): APIList<SharedResource, ShareData, ShareData>;`
`16`	`16`	`property(id: number): APIResource<Property, import("./models/HTTP").QueryParams, import("./models/HTTP").QueryParams>;`
`17`	`17`	`}`
`18`	`18`	`export default APIResourceFile;`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@bitbar/cloud-api-client",`
`3`		`- "version": "1.4.5",`
	`3`	`+ "version": "1.4.6",`
`4`	`4`	`"description": "Bitbar Cloud API Client for JavaScript",`
`5`	`5`	`"main": "dist/bitbar-cloud-api-client.min.js",`
`6`	`6`	`"types": "dist/index.d.ts",`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ export class APIResourceDeviceGroup extends APIResource<DeviceGroup> {`
`52`	`52`
`53`	`53`	`// /device-groups/{id}/share`
`54`	`54`	`share() {`
`55`		`- return new APIList<SharedResource, NoQueryParams, ShareData>(this).push('share');`
	`55`	`+ return new APIList<SharedResource, ShareData, ShareData>(this).push('share');`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ export class APIResourceFile extends APIResource<UserFile> {`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`share() {`
`43`		`- return new APIList<SharedResource, ShareData>(this).push('share');`
	`43`	`+ return new APIList<SharedResource, ShareData, ShareData>(this).push('share');`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`property(id: number) {`