Skip to content

Commit 986097f

Browse files
committed
Done a fix to property_control and example property
1 parent 7b12ab1 commit 986097f

3 files changed

Lines changed: 9 additions & 7 deletions

File tree

addons/pandora/ui/components/properties/property_control.gd

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ func refresh() -> void:
2626

2727
func update_field_settings(field_settings: Dictionary) -> void:
2828
_load_fields_settings()
29-
var fs_idx := _fields_settings.find(func(fs: Dictionary): return fs["name"] == field_settings["name"])
29+
var fs := _fields_settings.filter(func(dic: Dictionary): return dic["name"] == field_settings["name"])[0] as Dictionary
30+
var fs_idx := _fields_settings.find(fs)
3031
_fields_settings[fs_idx] = field_settings
3132
Pandora.update_fields_settings.emit(type)
3233

pandora/extensions/configuration.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"type": "STRING"
2525
},
2626
{
27-
"enabled": false,
27+
"enabled": true,
2828
"name": "Quantity",
2929
"settings": {
3030
"max_value": 100.0,

pandora/extensions/test_property/ui_component/test_property.gd

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,13 @@ func _ready() -> void:
3131
property_value_changed.emit(current_property))
3232

3333
func refresh() -> void:
34+
for field_settings in _fields_settings:
35+
if field_settings["name"] == "Quantity":
36+
spin_box.visible = field_settings["enabled"]
37+
elif field_settings["name"] == "Item Name":
38+
spin_box.visible = field_settings["enabled"]
39+
3440
if _property != null:
35-
for field_settings in _fields_settings:
36-
if field_settings["name"] == "Quantity":
37-
spin_box.visible = field_settings["enabled"]
38-
elif field_settings["name"] == "Item Name":
39-
spin_box.visible = field_settings["enabled"]
4041
if _property.get_setting(TestPropertyType.SETTING_MIN_VALUE):
4142
spin_box.min_value = _property.get_setting(TestPropertyType.SETTING_MIN_VALUE) as int
4243
if _property.get_setting(TestPropertyType.SETTING_MAX_VALUE):

0 commit comments

Comments
 (0)