Skip to content

HACKNET: spendHashes handles invalid targets inconsistently #1785

Open
@gmcew

Description

@gmcew

from #1782, ns.hacknet.spendHashes handles different invalid targets inconsistently, and additionally differently from the UI validity check logic.

To avoid making a breaking change with ns.hacknet.spendHashes (https://github.com/bitburner-official/bitburner-src/blob/d824cd4fa6692ca1e04173b892278b79587a88fb/src/Hacknet/HacknetHelpers.tsx), I don't touch it in this PR, but I want to hear your opinions about it:

When it sees a hashserver, it returns false without printing a warning.
Home and private servers are valid targets. It's inconsistent with how we determine the target in the UI. It's not exploitable, so it's not urgent.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions