qml: skip wallet setup after startup shutdown

Avoid treating a late successful init result as node-ready once shutdown has already been requested. This keeps the wallet controller from rebuilding GUI wallet state while Core is shutting down, fixing qml_test_shutdown hangs during load_on_startup shutdown.

Author: johnny9

qml/bitcoin.cpp

@@ -359,19 +359,21 @@ int QmlGuiMain(int argc, char* argv[])
     NodeModel node_model{*node};
     node_model.addStartupWarnings(startup_warnings);
     QmlInitExecutor init_executor{*node};
+    bool shutdown_requested{false};
 #ifdef ENABLE_WALLET
     std::unique_ptr<WalletQmlController> wallet_controller;
     if (wallet_enabled) {
         wallet_controller = std::make_unique<WalletQmlController>(*node);
-        QObject::connect(&init_executor, &QmlInitExecutor::initializeResult, wallet_controller.get(), [wallet_controller = wallet_controller.get()](bool success) {
-            if (success) {
-                wallet_controller->initialize();
-            }
-        });
+        QObject::connect(
+            &init_executor, &QmlInitExecutor::initializeResult, wallet_controller.get(),
+            [wallet_controller = wallet_controller.get(), node = node.get(), &shutdown_requested](bool success) {
+                if (success && !shutdown_requested && !node->shutdownRequested()) {
+                    wallet_controller->initialize();
+                }
+            });
     }
 #endif
     QObject::connect(&node_model, &NodeModel::requestedInitialize, &init_executor, &QmlInitExecutor::initialize);
-    bool shutdown_requested{false};
     QObject::connect(&node_model, &NodeModel::requestedShutdown, [&] {
         if (shutdown_requested) {
             return;

qml/models/nodemodel.cpp

@@ -426,6 +426,11 @@ void NodeModel::requestShutdown()
 
 void NodeModel::initializeResult(bool success, interfaces::BlockAndHeaderTipInfo tip_info)
 {
+    if (success && (m_shutdown_requested || m_node.shutdownRequested())) {
+        requestShutdown();
+        return;
+    }
+
     if (!success) {
         if (m_startup_failure_dialog_shown) {
             requestShutdown();

test/test_nodemodel.cpp

@@ -144,6 +144,7 @@ private Q_SLOTS:
     void requestShutdownEmitsOnlyOnce();
     void initializationFailureRequestsShutdownWhenCoreWasInterrupted();
     void initializationFailureWithoutCoreInterruptOnlySetsErrorState();
+    void initializationSuccessDuringCoreShutdownSkipsReadyState();
     void destructorUnsubscribesCoreSignalsBeforeStoppingPolling();
     void nodeNotificationHandlersUpdateModelThroughQueuedSignals();
     void blockTipUpdatesQueuedAcrossThreadsRetainPayloadValues();
@@ -413,6 +414,27 @@ void NodeModelTests::initializationFailureWithoutCoreInterruptOnlySetsErrorState
     QCOMPARE(initialized_spy.count(), 1);
 }
 
+void NodeModelTests::initializationSuccessDuringCoreShutdownSkipsReadyState()
+{
+    NiceMock<MockNode> node;
+    MempoolState mempool;
+    InstallDefaultHandlers(node);
+    InstallMempoolGetters(node, mempool);
+    ON_CALL(node, shutdownRequested()).WillByDefault(Return(true));
+
+    NodeModel model{node};
+    WaitForInitialMempoolRefresh(mempool);
+
+    QSignalSpy shutdown_spy{&model, &NodeModel::requestedShutdown};
+    QSignalSpy initialized_spy{&model, &NodeModel::nodeInitialized};
+    QSignalSpy ready_state_spy{&model, &NodeModel::setTimeRatioListInitial};
+    model.initializeResult(true, {});
+
+    QCOMPARE(shutdown_spy.count(), 1);
+    QCOMPARE(initialized_spy.count(), 0);
+    QCOMPARE(ready_state_spy.count(), 0);
+}
+
 void NodeModelTests::destructorUnsubscribesCoreSignalsBeforeStoppingPolling()
 {
     NiceMock<MockNode> node;